From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933542AbdHYPJZ (ORCPT ); Fri, 25 Aug 2017 11:09:25 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:38728 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933467AbdHYPJY (ORCPT ); Fri, 25 Aug 2017 11:09:24 -0400 Date: Fri, 25 Aug 2017 08:09:16 -0700 From: Christoph Hellwig To: Hans de Goede Cc: Christoph Hellwig , Arnd Bergmann , Greg Kroah-Hartman , Michael Thayer , "Knut St . Osmundsen" , Larry Finger , linux-kernel@vger.kernel.org Subject: Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest integration Message-ID: <20170825150916.GA353@infradead.org> References: <20170825143732.10836-1-hdegoede@redhat.com> <20170825143732.10836-2-hdegoede@redhat.com> <20170825145806.GA6706@infradead.org> <9e9b6c22-50dd-4935-9dfd-7c8a885f75e9@redhat.com> <20170825150324.GA23830@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 25, 2017 at 05:06:52PM +0200, Hans de Goede wrote: > I'm afraid that the userspace API is more or less a take it > or leave it kinda deal, we can do small cleanups, but an > entire re-design is out of the question. The vboxguest code > has a long (too long) out of tree history and the same ioctl > interface is used by VirtualBox upstream on Windows, Mac OS X, > the BSDs and Solaris, so we cannot just go and break it to > out hart's content. Then hard out NAK for the code.