From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] modem-manager: update dependencies
Date: Fri, 25 Aug 2017 16:02:30 +0200 [thread overview]
Message-ID: <20170825160230.7535243d@windsurf> (raw)
In-Reply-To: <20170825123015.10667-1-aleksander@aleksander.es>
Hello,
Thanks for your contribution!
On Fri, 25 Aug 2017 14:30:15 +0200, Aleksander Morgado wrote:
> The dbus-glib package isn't a dependency since ModemManager 1.0, which
> is based on libglib2's GDBus implementation.
And libglib2 GDBus implementation is built unconditionally, regardless
of whether the DBus package is enabled or not ?
> Also, explicitly set libglib2 as dependency, which currently was being
> implicitly included by libgudev. The next major ModemManager release
> will have udev/libgudev as optional packages, while libglib2 is
> definitely not going to be ever optional.
>
> Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> ---
> package/modem-manager/modem-manager.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> index 1eea355f5..c2999dc2e 100644
> --- a/package/modem-manager/modem-manager.mk
> +++ b/package/modem-manager/modem-manager.mk
> @@ -9,7 +9,7 @@ MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
> MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
> MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
> MODEM_MANAGER_LICENSE_FILES = COPYING
> -MODEM_MANAGER_DEPENDENCIES = host-pkgconf udev dbus-glib host-intltool libgudev
> +MODEM_MANAGER_DEPENDENCIES = host-pkgconf udev host-intltool libglib2 libgudev
Then you also need to:
1. Remove select BR2_PACKAGE_DBUS_GLIB from Config.in
2. add select BR2_PACKAGE_LIBGLIB2 in Config.in
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-08-25 14:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 12:30 [Buildroot] [PATCH] modem-manager: update dependencies Aleksander Morgado
2017-08-25 14:02 ` Thomas Petazzoni [this message]
2017-08-25 14:09 ` Aleksander Morgado
2017-08-25 14:21 ` [Buildroot] [PATCH v2] " Aleksander Morgado
2017-08-25 20:41 ` Thomas Petazzoni
2017-08-27 7:05 ` Aleksander Morgado
2017-08-27 7:23 ` Thomas Petazzoni
2017-08-27 10:00 ` Aleksander Morgado
2017-08-27 10:42 ` [Buildroot] [PATCH v3] " Aleksander Morgado
2017-08-30 21:30 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825160230.7535243d@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.