From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Colin King <colin.king@canonical.com>,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm_tis: make array cmd_getticks static const to shink object code size
Date: Fri, 25 Aug 2017 20:31:20 +0300 [thread overview]
Message-ID: <20170825173120.l2mp4tckdtyixzii@linux.intel.com> (raw)
In-Reply-To: <20170825165242.GA5254@obsidianresearch.com>
On Fri, Aug 25, 2017 at 10:52:42AM -0600, Jason Gunthorpe wrote:
> On Fri, Aug 25, 2017 at 05:45:05PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Don't populate array cmd_getticks on the stack, instead make it static
> > const. Makes the object code smaller by over 160 bytes:
> >
> > Before:
> > text data bss dec hex filename
> > 18813 3152 128 22093 564d drivers/char/tpm/tpm_tis_core.o
> >
> > After:
> > text data bss dec hex filename
> > 18554 3248 128 21930 55aa drivers/char/tpm/tpm_tis_core.o
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
>
> Jason
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
next prev parent reply other threads:[~2017-08-25 17:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 16:45 [PATCH] tpm_tis: make array cmd_getticks static const to shink object code size Colin King
2017-08-25 16:52 ` Jason Gunthorpe
2017-08-25 17:31 ` Jarkko Sakkinen [this message]
2017-09-06 11:31 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825173120.l2mp4tckdtyixzii@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=colin.king@canonical.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.