From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] vgacon, x86/boot: Prevent faulty bootparams.screeninfo from causing harm
Date: Sun, 27 Aug 2017 15:05:19 +0000 [thread overview]
Message-ID: <20170827150519.GA32693@kroah.com> (raw)
In-Reply-To: <1503842206-30039-1-git-send-email-jschoenh@amazon.de>
On Sun, Aug 27, 2017 at 03:56:46PM +0200, Jan H. Schönherr wrote:
> If a zero for the number of colums or rows manages to slip through,
> gotoxy() will underflow vc->vc_pos, causing the next action on the
> referenced memory to end with a page fault.
>
> Make the check in vgacon more pessimistic to prevent that. Also change
> a similar check in the x86 boot code with a similar problem.
>
> Signed-off-by: Jan H. Schönherr <jschoenh@amazon.de>
> ---
> Let me know, if I should split this into two patches.
>
> arch/x86/boot/compressed/misc.c | 3 +--
> drivers/video/console/vgacon.c | 5 ++---
> 2 files changed, 3 insertions(+), 5 deletions(-)
Why send this patch to me?
And yes, of course you have to split this up, these two files have
nothing to do with each other...
greg k-h
next prev parent reply other threads:[~2017-08-27 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-27 13:56 [PATCH] vgacon, x86/boot: Prevent faulty bootparams.screeninfo from causing harm Jan H. Schönherr
2017-08-27 15:05 ` Greg Kroah-Hartman [this message]
2017-08-27 16:47 ` Jan H. Schönherr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170827150519.GA32693@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.