From: Christoph Hellwig <hch@lst.de>
To: Ido Schimmel <idosch@mellanox.com>
Cc: Christoph Hellwig <hch@lst.de>,
tj@kernel.org, xiaolong.ye@intel.com, mlxsw@mellanox.com,
michaelsh@mellanox.com, linux-ide@vger.kernel.org
Subject: Re: Regression due to "libata: implement SECURITY PROTOCOL IN/OUT"
Date: Sun, 27 Aug 2017 19:03:48 +0200 [thread overview]
Message-ID: <20170827170348.GA22437@lst.de> (raw)
In-Reply-To: <20170827105331.GA18386@shredder.mtl.com>
Does this make your boot issue go away?
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index fa7dd4394c02..697f5f896b19 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -2079,6 +2079,8 @@ unsigned int ata_read_log_page(struct ata_device *dev, u8 log,
*/
if (ap_flags & ATA_FLAG_NO_LOG_PAGE)
return AC_ERR_DEV;
+ if (dev->horkage & ATA_HORKAGE_NO_LOG_PAGE)
+ return AC_ERR_DEV;
retry:
ata_tf_init(dev, &tf);
@@ -4578,6 +4580,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
{ "WDC WD3000JD-*", NULL, ATA_HORKAGE_WD_BROKEN_LPM },
{ "WDC WD3200JD-*", NULL, ATA_HORKAGE_WD_BROKEN_LPM },
+
+ { "M.2 (S42) 3ME3", NULL, ATA_HORKAGE_NO_LOG_PAGE },
/* End Marker */
{ }
};
diff --git a/include/linux/libata.h b/include/linux/libata.h
index 931c32f1f18d..9e927ae7fced 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -438,6 +438,7 @@ enum {
ATA_HORKAGE_NO_DMA_LOG = (1 << 23), /* don't use DMA for log read */
ATA_HORKAGE_NOTRIM = (1 << 24), /* don't use TRIM */
ATA_HORKAGE_MAX_SEC_1024 = (1 << 25), /* Limit max sects to 1024 */
+ ATA_HORKAGE_NO_LOG_PAGE = (1 << 26), /* Doesn't like Get Log Page */
/* DMA mask for user DMA control: User visible values; DO NOT
renumber */
next prev parent reply other threads:[~2017-08-27 17:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 11:29 Regression due to "libata: implement SECURITY PROTOCOL IN/OUT" Ido Schimmel
2017-08-24 12:07 ` Christoph Hellwig
2017-08-24 12:18 ` Ido Schimmel
2017-08-26 17:15 ` Ido Schimmel
2017-08-27 9:05 ` Christoph Hellwig
2017-08-27 10:53 ` Ido Schimmel
2017-08-27 17:03 ` Christoph Hellwig [this message]
2017-08-27 18:25 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170827170348.GA22437@lst.de \
--to=hch@lst.de \
--cc=idosch@mellanox.com \
--cc=linux-ide@vger.kernel.org \
--cc=michaelsh@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=tj@kernel.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.