From: Peter Xu <peterx@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, shorne@gmail.com, quintela@redhat.com,
mreitz@redhat.com, lvivier@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] migration: Reset rather than destroy main_thread_load_event
Date: Mon, 28 Aug 2017 17:08:45 +0800 [thread overview]
Message-ID: <20170828090845.GP14174@pxdev.xzpeter.org> (raw)
In-Reply-To: <20170825141940.20740-2-dgilbert@redhat.com>
On Fri, Aug 25, 2017 at 03:19:39PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> migration_incoming_state_destroy doesn't really destroy, it cleans up.
> After a loadvm it's called, but the loadvm command can be run twice,
> and so destroying an init-once mutex breaks on the second loadvm.
>
> Reported-by: Stafford Horne <shorne@gmail.com>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2017-08-28 9:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 14:19 [Qemu-devel] [PATCH 0/2] Fix double loadvm failure Dr. David Alan Gilbert (git)
2017-08-25 14:19 ` [Qemu-devel] [PATCH 1/2] migration: Reset rather than destroy main_thread_load_event Dr. David Alan Gilbert (git)
2017-08-25 15:28 ` Peter Maydell
2017-08-25 15:51 ` Dr. David Alan Gilbert
2017-08-28 9:01 ` Peter Xu
2017-08-26 13:55 ` Stafford Horne
2017-08-28 9:08 ` Peter Xu [this message]
2017-08-25 14:19 ` [Qemu-devel] [PATCH 2/2] snapshot/tests: Try loadvm twice Dr. David Alan Gilbert (git)
2017-08-28 9:10 ` Peter Xu
2017-09-05 11:32 ` Dr. David Alan Gilbert
2017-09-06 14:19 ` [Qemu-devel] [PATCH 0/2] Fix double loadvm failure Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828090845.GP14174@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.