From: Stephen Hemminger <stephen@networkplumber.org>
To: Alexander Aring <aring@mojatatu.com>
Cc: jhs@mojatatu.com, yotamg@mellanox.com, xiyou.wangcong@gmail.com,
jiri@resnulli.us, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 1/4] tc: m_ife: allow ife type to zero
Date: Mon, 28 Aug 2017 12:34:13 -0700 [thread overview]
Message-ID: <20170828123413.2283b2e1@xeon-e3> (raw)
In-Reply-To: <20170828190738.26829-2-aring@mojatatu.com>
On Mon, 28 Aug 2017 15:07:35 -0400
Alexander Aring <aring@mojatatu.com> wrote:
> This patch allows to set an ethertype for IFE which is zero. There is no
> kernel side validation which forbids a type to zero.
>
> Signed-off-by: Alexander Aring <aring@mojatatu.com>
> ---
> tc/m_ife.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tc/m_ife.c b/tc/m_ife.c
> index e3521e62..e05e2276 100644
> --- a/tc/m_ife.c
> +++ b/tc/m_ife.c
> @@ -63,6 +63,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,
> char dbuf[ETH_ALEN];
> char sbuf[ETH_ALEN];
> __u16 ife_type = 0;
> + int user_type = 0;
Please use bool if it is a flag value
next prev parent reply other threads:[~2017-08-28 19:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 19:07 [PATCH iproute2 0/4] tc: m_ife: handle IFE ethertype value Alexander Aring
2017-08-28 19:07 ` [PATCH iproute2 1/4] tc: m_ife: allow ife type to zero Alexander Aring
2017-08-28 19:34 ` Stephen Hemminger [this message]
2017-08-28 22:16 ` Jamal Hadi Salim
2017-08-28 19:07 ` [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format Alexander Aring
2017-08-28 19:33 ` Stephen Hemminger
2017-08-28 22:18 ` Jamal Hadi Salim
2017-08-28 22:37 ` Stephen Hemminger
2017-08-28 22:56 ` Jamal Hadi Salim
2017-08-28 19:07 ` [PATCH iproute2 3/4] tc: m_ife: report about kernels default type Alexander Aring
2017-08-28 22:18 ` Jamal Hadi Salim
2017-08-28 19:07 ` [PATCH iproute2 4/4] man: tc-ife: add default type note Alexander Aring
2017-08-28 22:19 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828123413.2283b2e1@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=aring@mojatatu.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.