All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: conntrack: don't log "invalid" icmpv6 connections
Date: Mon, 28 Aug 2017 17:51:39 +0200	[thread overview]
Message-ID: <20170828155139.GA20496@salvia> (raw)
In-Reply-To: <20170825005941.8773-1-fw@strlen.de>

On Fri, Aug 25, 2017 at 02:59:41AM +0200, Florian Westphal wrote:
> When enabling logging for invalid connections we currently also log most
> icmpv6 types, which we don't track intentionally (e.g. neigh discovery).
> "invalid" should really mean "invalid", i.e. short header or bad checksum.
> 
> We don't do any logging for icmp(v4) either, its just useless noise.

Applied, thanks.

      reply	other threads:[~2017-08-28 15:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25  0:59 [PATCH nf-next] netfilter: conntrack: don't log "invalid" icmpv6 connections Florian Westphal
2017-08-28 15:51 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170828155139.GA20496@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.