All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: mhocko@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org,
	mgorman@suse.de, vbabka@suse.cz
Subject: Re: [PATCH] mm: Use WQ_HIGHPRI for mm_percpu_wq.
Date: Mon, 28 Aug 2017 16:09:24 -0700	[thread overview]
Message-ID: <20170828230924.GG491396@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20170828230256.GF491396@devbig577.frc2.facebook.com>

Hey, again.

On Mon, Aug 28, 2017 at 04:02:56PM -0700, Tejun Heo wrote:
> Hmm... all these is mostly because workqueue lost the "ignore
> concurrency management" flag a while back while converting WQ_HIGHPRI
> to mean high nice priority instead of the top of the queue w/o
> concurrency management.  Resurrecting that shouldn't be too difficult.
> I'll get back to you soon.

Can you please try this patch and see how the work item behaves w/
WQ_HIGHPRI set?  It disables concurrency mgmt for highpri work items
which makes sense anyway.

Thanks.

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index ca937b0..14b6bce 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -2021,7 +2021,7 @@ __acquires(&pool->lock)
 {
 	struct pool_workqueue *pwq = get_work_pwq(work);
 	struct worker_pool *pool = worker->pool;
-	bool cpu_intensive = pwq->wq->flags & WQ_CPU_INTENSIVE;
+	bool cpu_intensive = pwq->wq->flags & (WQ_CPU_INTENSIVE | WQ_HIGHPRI);
 	int work_color;
 	struct worker *collision;
 #ifdef CONFIG_LOCKDEP


-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-08-28 23:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1503921210-4603-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>
2017-08-28 12:10 ` [PATCH] mm: Use WQ_HIGHPRI for mm_percpu_wq Michal Hocko
2017-08-28 17:06   ` Tejun Heo
2017-08-28 22:15     ` Tetsuo Handa
2017-08-28 23:02       ` Tejun Heo
2017-08-28 23:09         ` Tejun Heo [this message]
2017-08-29 11:14           ` Tetsuo Handa
2017-08-29 14:38             ` Tejun Heo
2017-08-29 21:41               ` Tejun Heo
2017-08-30 13:51                 ` Tetsuo Handa
2017-08-31  1:46                   ` Tejun Heo
2017-08-31 14:52                     ` Tetsuo Handa
2017-08-31 15:25                       ` Michal Hocko
2017-08-31 22:07                         ` Tetsuo Handa
2017-09-01 13:47                           ` Tejun Heo
2017-09-01 14:29                             ` Tetsuo Handa
2017-08-29 13:33     ` Michal Hocko
2017-08-29 14:33       ` Tejun Heo
2017-08-29 20:29         ` Tetsuo Handa
2017-08-30  6:40           ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170828230924.GG491396@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.