From: David Gibson <david@gibson.dropbear.id.au>
To: Ram Pai <linuxram@us.ibm.com>
Cc: Paul Mackerras <paulus@ozlabs.org>,
Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Alexander Graf <agraf@suse.de>,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node
Date: Tue, 29 Aug 2017 11:40:30 +1000 [thread overview]
Message-ID: <20170829014030.GD2578@umbus.fritz.box> (raw)
In-Reply-To: <20170828175356.GB26893@ram.oc3035372033.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On Mon, Aug 28, 2017 at 10:53:56AM -0700, Ram Pai wrote:
> On Thu, Aug 24, 2017 at 12:54:48PM +1000, Paul Mackerras wrote:
> >
> > We could either have two u16 fields for the number of keys for data
> > and instruction, or we could have a u32 field for the number of keys
> > and a separate bit in the flags field to indicate that instruction
> > keys are supported. Which would be preferable?
>
> the second choice is more confusion-proof; to me atleast.
>
> The first choice gives a illusion that there are 'x' number of data keys
> and 'y' number of instruction keys; which is not exactly true.
Ah.. can you elaborate?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-29 1:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 20:00 [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node Thiago Jung Bauermann
2017-08-22 2:02 ` David Gibson
2017-08-23 23:14 ` Thiago Jung Bauermann
2017-08-24 1:34 ` David Gibson
2017-08-22 7:17 ` no-reply
2017-08-24 2:54 ` Paul Mackerras
2017-08-24 4:02 ` David Gibson
2017-08-24 4:15 ` Paul Mackerras
2017-08-24 4:27 ` David Gibson
2017-08-24 18:11 ` Ram Pai
2017-08-25 4:23 ` David Gibson
2017-08-28 17:50 ` Ram Pai
2017-08-29 1:57 ` David Gibson
2017-08-28 17:53 ` Ram Pai
2017-08-29 1:40 ` David Gibson [this message]
2017-08-29 16:31 ` Ram Pai
2017-08-30 0:43 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829014030.GD2578@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=bauerman@linux.vnet.ibm.com \
--cc=linuxram@us.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@ozlabs.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.