From: Cornelia Huck <cohuck@redhat.com>
To: Yi Min Zhao <zyimin@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, borntraeger@de.ibm.com,
pasic@linux.vnet.ibm.com, pmorel@linux.vnet.ibm.com,
agraf@suse.de, richard.henderson@linaro.org
Subject: Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback
Date: Tue, 29 Aug 2017 11:57:27 +0200 [thread overview]
Message-ID: <20170829115727.4dacb471.cohuck@redhat.com> (raw)
In-Reply-To: <8f60cc33-8438-9d5a-56bd-7b56c8abee4e@linux.vnet.ibm.com>
On Tue, 29 Aug 2017 17:51:43 +0800
Yi Min Zhao <zyimin@linux.vnet.ibm.com> wrote:
> 在 2017/8/29 下午5:33, Cornelia Huck 写道:
> > My question was whether virtio-pci works with your patches on top at
> > all - last time I checked on master, virtio-pci devices failed to
> > realize with a "msi-x is mandatory" message.
> >
> >
> I tested. virtio-pci works fine. The message "msix is mandatory" means
> we only support
> msix interrupt. If virtio-pci device (like virtio-rng) doesn't support
> msix, we don't allow it
> to plug.
Ah, that's it (it's a bit strange that not all virtio-pci devices
support msi-x). I can add a virtio-net-pci device just fine.
(Maybe we can enhance the message so that it is clear that it refers to
that particular device?)
> I thinik this is not related to iommu replay.
This question was unrelated to this particular patch, more to the whole
series :)
next prev parent reply other threads:[~2017-08-29 9:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 8:04 [Qemu-devel] [PATCH 0/4] four zpci patches Yi Min Zhao
2017-08-28 8:04 ` [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix() Yi Min Zhao
2017-08-28 14:51 ` Cornelia Huck
2017-08-29 4:32 ` Yi Min Zhao
2017-08-29 8:00 ` Cornelia Huck
2017-08-29 8:05 ` Yi Min Zhao
2017-08-29 8:12 ` Yi Min Zhao
2017-08-29 8:22 ` Cornelia Huck
2017-08-29 8:33 ` Yi Min Zhao
2017-08-29 8:58 ` Cornelia Huck
2017-08-30 9:47 ` Cornelia Huck
2017-08-28 8:04 ` [Qemu-devel] [PATCH 2/4] s390x/pci: remove idx from msix msg data Yi Min Zhao
2017-08-28 15:04 ` Cornelia Huck
2017-08-29 4:33 ` Yi Min Zhao
2017-08-28 8:04 ` [Qemu-devel] [PATCH 3/4] s390x/pci: fixup ind_offset of msix routing entry Yi Min Zhao
2017-08-28 15:33 ` Cornelia Huck
2017-08-29 4:39 ` Yi Min Zhao
2017-08-28 8:04 ` [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback Yi Min Zhao
2017-08-28 15:57 ` Cornelia Huck
2017-08-29 4:46 ` Yi Min Zhao
2017-08-29 8:07 ` Cornelia Huck
2017-08-29 8:26 ` Yi Min Zhao
2017-08-29 9:33 ` Cornelia Huck
2017-08-29 9:49 ` Cornelia Huck
2017-08-29 9:53 ` Yi Min Zhao
2017-08-29 9:51 ` Yi Min Zhao
2017-08-29 9:57 ` Cornelia Huck [this message]
2017-08-29 10:00 ` Yi Min Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829115727.4dacb471.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=zyimin@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.