From: Greg KH <gregkh@linuxfoundation.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Andreas Ziegler <andreas.ziegler@fau.de>,
devel@driverdev.osuosl.org,
Yan-Hsuan Chuang <yhchuang@realtek.com>,
Birming Chiu <birming@realtek.com>,
netdev <netdev@vger.kernel.org>,
Steven Ting <steventing@realtek.com>
Subject: Re: [PATCH] staging: r8822be: Fix typo for CONFIG_RTLWIFI_DEBUG
Date: Tue, 29 Aug 2017 16:42:16 +0200 [thread overview]
Message-ID: <20170829144216.GA22295@kroah.com> (raw)
In-Reply-To: <fcab4e04-be42-5a05-c5ad-4947d2d41164@lwfinger.net>
On Tue, Aug 29, 2017 at 09:10:10AM -0500, Larry Finger wrote:
> On 08/29/2017 06:30 AM, Andreas Ziegler wrote:
> > The debugging output in deinit_priv is guarded by an #ifdef using
> > CONFIG_RTL_DEBUG. This symbol does not exist and should be
> > CONFIG_RTLWIFI_DEBUG instead.
> >
> > Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
>
> NACK.
>
> Yes, there is a problem; however, CONFIG_RTLWIFI_DEBUG is not the value that
> should be used. That one is reserved for the non-staging drivers in
> drivers/net/wireless/realtek/rtlwifi/. The correct symbol for r8822be is
> CONFIG_RTLWIFI_DEBUG_ST.
Yeah, kbuild just blew up on this as well, I wonder why my local build
testing didn't see that :(
Now dropped.
greg k-h
next prev parent reply other threads:[~2017-08-29 14:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 17:46 [PATCH 0/8] staging: Add new driver for RTL8822BE Larry Finger
2017-08-17 17:46 ` [PATCH 1/8] staging: r8822be: Add existing rtlwifi and rtl_pci parts for new driver Larry Finger
2017-08-17 17:46 ` [PATCH 2/8] staging: r8822be: Copy existing btcoexist code into staging Larry Finger
2017-08-17 17:46 ` [PATCH 3/8] staging: r8822be: Add r8822be btcoexist routines to staging Larry Finger
2017-08-17 17:46 ` [PATCH 4/8] staging: r8822be: Add code for halmac sub-driver Larry Finger
2017-08-29 10:59 ` Andreas Ziegler
2017-08-29 11:26 ` Greg KH
2017-08-29 11:30 ` [PATCH] staging: r8822be: Fix typo for CONFIG_RTLWIFI_DEBUG Andreas Ziegler
2017-08-29 14:10 ` Larry Finger
2017-08-29 14:42 ` Greg KH [this message]
2017-08-30 7:58 ` Andreas Ziegler
2017-08-30 16:28 ` Larry Finger
2017-09-03 0:18 ` kbuild test robot
2017-08-17 17:46 ` [PATCH 5/8] staging: r8822be: Add phydm mini driver Larry Finger
2017-08-17 17:46 ` [PATCH 6/8] staging: r8822be: Add the driver code Larry Finger
2017-08-17 17:46 ` [PATCH 7/8] staging: r8822be: Add Makefiles and Kconfig for new driver Larry Finger
2017-08-19 20:19 ` kbuild test robot
2017-08-17 17:46 ` [PATCH 8/8] staging: rtlwifi: Reviewers fixes Larry Finger
2017-08-17 20:46 ` Thoughts on staging and on fixing up drivers? Dan Carpenter
2017-08-17 21:07 ` tedheadster
2017-08-18 1:22 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829144216.GA22295@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=andreas.ziegler@fau.de \
--cc=birming@realtek.com \
--cc=devel@driverdev.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=steventing@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.