All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: David Miller <davem@davemloft.net>
Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org,
	samuel@sortiz.org, linux-kernel@vger.kernel.org,
	fengguang.wu@intel.com, geert@linux-m68k.org
Subject: Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into the kernel
Date: Tue, 29 Aug 2017 21:05:03 +0200	[thread overview]
Message-ID: <20170829190503.GA31452@kroah.com> (raw)
In-Reply-To: <20170829.104945.1786969849973428586.davem@davemloft.net>

On Tue, Aug 29, 2017 at 10:49:45AM -0700, David Miller wrote:
> From: Greg KH <gregkh@linuxfoundation.org>
> Date: Tue, 29 Aug 2017 19:46:22 +0200
> 
> > When moving the IRDA code out of net/ into drivers/staging/irda/net, the
> > link order changes when IRDA is built into the kernel.  That causes a
> > kernel crash at boot time as netfilter isn't initialized yet.
> > 
> > To fix this, build and link the irda networking code in the same exact
> > order that it was previously before the move.
> > 
> > Reported-by: kernel test robot <fengguang.wu@intel.com>
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
> 
> Greg, just change the initializer in IRDA so that it will run
> after subsys_init() when built statically.
> 
> IRDA is definitely not the first pontentially statically built
> thing that needs netlink up and available.

Ok, will do that tomorrow and test it and send you the patch.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: David Miller <davem@davemloft.net>
Cc: devel@driverdev.osuosl.org, samuel@sortiz.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	geert@linux-m68k.org, fengguang.wu@intel.com
Subject: Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into the kernel
Date: Tue, 29 Aug 2017 21:05:03 +0200	[thread overview]
Message-ID: <20170829190503.GA31452@kroah.com> (raw)
In-Reply-To: <20170829.104945.1786969849973428586.davem@davemloft.net>

On Tue, Aug 29, 2017 at 10:49:45AM -0700, David Miller wrote:
> From: Greg KH <gregkh@linuxfoundation.org>
> Date: Tue, 29 Aug 2017 19:46:22 +0200
> 
> > When moving the IRDA code out of net/ into drivers/staging/irda/net, the
> > link order changes when IRDA is built into the kernel.  That causes a
> > kernel crash at boot time as netfilter isn't initialized yet.
> > 
> > To fix this, build and link the irda networking code in the same exact
> > order that it was previously before the move.
> > 
> > Reported-by: kernel test robot <fengguang.wu@intel.com>
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
> 
> Greg, just change the initializer in IRDA so that it will run
> after subsys_init() when built statically.
> 
> IRDA is definitely not the first pontentially statically built
> thing that needs netlink up and available.

Ok, will do that tomorrow and test it and send you the patch.

thanks,

greg k-h

  reply	other threads:[~2017-08-29 19:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29  7:09 [PATCH net-next] staging: irda: update MAINTAINERS Greg Kroah-Hartman
2017-08-29  7:09 ` Greg Kroah-Hartman
2017-08-29  9:14 ` [PATCH net-next] staging: irda: force to be a kernel module Greg Kroah-Hartman
2017-08-29 16:35   ` David Miller
2017-08-29 16:35     ` David Miller
2017-08-29 17:26     ` Greg KH
2017-08-29 17:31       ` Greg KH
2017-08-29 17:46         ` [PATCH v2 net-next] irda: fix link order if IRDA is built into the kernel Greg KH
2017-08-29 17:46           ` Greg KH
2017-08-29 17:49           ` David Miller
2017-08-29 19:05             ` Greg KH [this message]
2017-08-29 19:05               ` Greg KH
2017-08-30 11:16           ` [PATCH v3 net-next] staging: irda: fix init level for irda core Greg KH
2017-08-30 17:15             ` David Miller
2017-08-29 17:40       ` [PATCH net-next] staging: irda: force to be a kernel module David Miller
2017-08-29 16:30 ` [PATCH net-next] staging: irda: update MAINTAINERS David Miller
2017-08-29 16:30   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170829190503.GA31452@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=fengguang.wu@intel.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=samuel@sortiz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.