Re: [morty][PATCH v2 4/6] recipes-core : packagegroups: hmi

[Denys Dmytriyenko <denys@ti.com>]

On Tue, Aug 29, 2017 at 03:56:56PM -0500, Manisha Agrawal wrote:
> 
> 
> On 08/29/2017 02:55 PM, Denys Dmytriyenko wrote:
> > On Tue, Aug 29, 2017 at 01:16:59PM -0400, Denys Dmytriyenko wrote:
> >> Manisha,
> >>
> >> From this:
> >>
> >>> recipes-core : packagegroups: hmi
> >> To this:
> >>
> >>> packagegroup-*-hmi: add hmi specific packagegroups
> >>
> >> On Tue, Aug 29, 2017 at 11:38:24AM -0500, Manisha Agrawal wrote:
> >>> Create packagegroup for HMI related demos. HMI is one of the focus
> >>> growth area for Sitara platform and demos planned for individual target end
> >>> equipments. Add evse-hmi demo to the packagegroup.
> >>>
> >>> Signed-off-by: Manisha Agrawal <manisha.agrawal@ti.com>
> >>> ---
> >>>  .../packagegroup-arago-tisdk-hmi-sdk-host.bb       | 26 +++++++++++++++++++++
> >>>  .../packagegroups/packagegroup-arago-tisdk-hmi.bb  | 27 ++++++++++++++++++++++
> >>>  2 files changed, 53 insertions(+)
> >>>  create mode 100755 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
> >>>  create mode 100755 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
> >>>
> >>> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
> >>> new file mode 100755
> >>> index 0000000..d58536c
> >>> --- /dev/null
> >>> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
> >>> @@ -0,0 +1,26 @@
> >>> +DESCRIPTION = "Task to add HMI related sources into the SDK"
> >> SUMMARY is missing.
> I see either SUMMARY or DESCRIPTION in other packagefroup files. Do you
> want me to rename the DESCRIPTION as SUMMARY or you want to see more
> information as part of SUMMARY. If yes, what additional information
> should I add there.

Please see my comment for patch #1 with the link.


> >>> +LICENSE = "BSD-3-Clause"
> 
> >> By default all OE metadata is licensed under MIT. Unless you have a very 
> >> specific need to license packagegroup under BSD, I'd suggest leaving it as is. 
> >> BTW since MIT is default, LICENSE can be omitted when inheriting packagegroup.

> This was suggested by Vivek. His comment was "Any user-space demo
> applications that we develop should be in TI BSD-3-clause license, as
> that’s the most friendliest and can be used by others (RTOS, VxWorks,
> etc.)…"

A packagegroup is not a user-space demo application, hence my comment above.


> >>> +PR = "r1"
> >> Not critical, but PR can also be omitted for new recipes.
> 
> I am keeping it for now else in future I will forget to add the
> revision. If I keep it, would you suggest it to be "r0" or "r1".

Doesn't matter, but it defaults to "r0".


> >>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> >>> +
> >>> +inherit packagegroup
> >>> +
> >>> +HMI = ""
> >>> +
> >>> +HMI_append_ti43x = " \
> >>> +    evse-hmi-src \
> >>> +"
> >>> +
> >>> +HMI_append_ti33x = " \
> >>> +    evse-hmi-src \
> >>> +"
> >>> +
> >>> +
> >>> +HMI_append_omap-a15 = " \
> >>> +    evse-hmi-src \
> >>> +"
> >>> +
> >>> +RDEPENDS_${PN} = "\
> >>> +    ${HMI} \
> >>> +"
> >>> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
> >>> new file mode 100755
> >>> index 0000000..9066c72
> >>> --- /dev/null
> >>> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
> >>> @@ -0,0 +1,27 @@
> >> Same comments here.
> >>
> >>
> >>> +DESCRIPTION = "Task to add HMI related packages"
> >>> +LICENSE = "BSD-3-Clause"
> >>> +PR = "r1"
> >>> +
> >>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> >>> +
> >>> +inherit packagegroup
> >>> +
> >>> +HMI = " \
> >>> +"
> >>> +
> >>> +
> >>> +HMI_append_ti33x = " \
> >>> +    evse-hmi \
> >>> +"
> >>> +
> >>> +HMI_append_ti43x = " \
> >>> +    evse-hmi \
> >>> +"
> >>> +
> >>> +HMI_append_omap-a15 = " \
> >>> +    evse-hmi \
> >>> +"
> >>> +
> >>> +
> >>> +RDEPENDS_${PN} = "\
> >>> +"
> > Also, you seem to be missing to add anything in RDEPENDS...
> >
> >
> >>> -- 
> >>> 2.13.0
> >>>
> >> _______________________________________________
> >> meta-arago mailing list
> >> meta-arago@arago-project.org
> >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>