From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v2 1/2] fs, xfs: perform dax_device lookup at mount Date: Tue, 29 Aug 2017 23:36:35 +0200 Message-ID: <20170829213635.GA8946@lst.de> References: <150389211501.25151.6477753201827914462.stgit@dwillia2-desk3.amr.corp.intel.com> <150389212075.25151.17146973298430877023.stgit@dwillia2-desk3.amr.corp.intel.com> <20170829212606.GC8608@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Jan Kara , "Darrick J. Wong" , "linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org" , linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel , linux-ext4 , Christoph Hellwig To: Dan Williams Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" List-Id: linux-ext4.vger.kernel.org On Tue, Aug 29, 2017 at 02:35:27PM -0700, Dan Williams wrote: > Actually, why not just do this directly in xfs_fs_mount()? I think I > can refactor this to not touch mount_bdev() and put all the details in > the per-fs mount/umount paths. Yes, and just cache in in the fs specific superblock. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F36E921CE748D for ; Tue, 29 Aug 2017 14:33:55 -0700 (PDT) Date: Tue, 29 Aug 2017 23:36:35 +0200 From: Christoph Hellwig Subject: Re: [PATCH v2 1/2] fs, xfs: perform dax_device lookup at mount Message-ID: <20170829213635.GA8946@lst.de> References: <150389211501.25151.6477753201827914462.stgit@dwillia2-desk3.amr.corp.intel.com> <150389212075.25151.17146973298430877023.stgit@dwillia2-desk3.amr.corp.intel.com> <20170829212606.GC8608@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: Jan Kara , "Darrick J. Wong" , "linux-nvdimm@lists.01.org" , linux-xfs@vger.kernel.org, linux-fsdevel , linux-ext4 , Christoph Hellwig List-ID: On Tue, Aug 29, 2017 at 02:35:27PM -0700, Dan Williams wrote: > Actually, why not just do this directly in xfs_fs_mount()? I think I > can refactor this to not touch mount_bdev() and put all the details in > the per-fs mount/umount paths. Yes, and just cache in in the fs specific superblock. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:46573 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbdH2Vgh (ORCPT ); Tue, 29 Aug 2017 17:36:37 -0400 Date: Tue, 29 Aug 2017 23:36:35 +0200 From: Christoph Hellwig Subject: Re: [PATCH v2 1/2] fs, xfs: perform dax_device lookup at mount Message-ID: <20170829213635.GA8946@lst.de> References: <150389211501.25151.6477753201827914462.stgit@dwillia2-desk3.amr.corp.intel.com> <150389212075.25151.17146973298430877023.stgit@dwillia2-desk3.amr.corp.intel.com> <20170829212606.GC8608@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Dan Williams Cc: Christoph Hellwig , linux-fsdevel , Jan Kara , "linux-nvdimm@lists.01.org" , "Darrick J. Wong" , linux-xfs@vger.kernel.org, linux-ext4 On Tue, Aug 29, 2017 at 02:35:27PM -0700, Dan Williams wrote: > Actually, why not just do this directly in xfs_fs_mount()? I think I > can refactor this to not touch mount_bdev() and put all the details in > the per-fs mount/umount paths. Yes, and just cache in in the fs specific superblock.