From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH for-4.13] nvme-pci: use dma memory for the host memory buffer descriptors
Date: Tue, 29 Aug 2017 18:00:12 -0400 [thread overview]
Message-ID: <20170829220012.GE4428@localhost.localdomain> (raw)
In-Reply-To: <20170828084718.29007-1-hch@lst.de>
On Mon, Aug 28, 2017@10:47:18AM +0200, Christoph Hellwig wrote:
> The NVMe 1.3 specification says in section 5.21.1.13:
>
> "After a successful completion of a Set Features enabling the host memory
> buffer, the host shall not write to the associated host memory region,
> buffer size, or descriptor list until the host memory buffer has been
> disabled."
>
> While this doesn't state that the descriptor list must remain accessible
> to the device it certainly implies it must remaing readable by the device.
>
> So switch to a dma coherent allocation for the descriptor list just to be
> safe - it's not like the cost for it matters compared to the actual
> memory buffers.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
Looks good to me.
Reviewed-by: Keith Busch <keith.busch at intel.com>
next prev parent reply other threads:[~2017-08-29 22:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 8:47 [PATCH for-4.13] nvme-pci: use dma memory for the host memory buffer descriptors Christoph Hellwig
2017-08-29 13:13 ` Christoph Hellwig
2017-08-29 13:59 ` Johannes Thumshirn
2017-08-29 14:50 ` Christoph Hellwig
2017-08-29 22:00 ` Keith Busch [this message]
2017-08-30 10:05 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829220012.GE4428@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.