All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: harsha <harshasharmaiitr@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG()
Date: Wed, 30 Aug 2017 07:58:14 +0200	[thread overview]
Message-ID: <20170830055814.GA2458@kroah.com> (raw)
In-Reply-To: <1504034462-13195-2-git-send-email-harshasharmaiitr@gmail.com>

On Wed, Aug 30, 2017 at 12:51:02AM +0530, harsha wrote:
> Fixes checkpatch.pl warning: Use WARN_ON() rather than BUG_ON() and BUG()
> 
> Signed-off-by: harsha <harshasharmaiitr@gmail.com>
> ---
>  drivers/staging/android/ion/ion.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 93e2c90..a2d36b3 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -66,7 +66,7 @@ static void ion_buffer_add(struct ion_device *dev,
>  			p = &(*p)->rb_right;
>  		} else {
>  			pr_err("%s: buffer already found.", __func__);
> -			BUG();
> +			WARN_ON();
>  		}
>  	}
>  

As you did not do anything different from the last submission where I
said this patch was not correct, I'm guessing that you don't want any
feedback.  So I'll go add you to my kill-file now and just ignore your
emails, as obviously, you are ignoring mine :(

good luck!

greg k-h

  reply	other threads:[~2017-08-30  5:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29 19:21 [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG() harsha
2017-08-29 19:21 ` harsha
2017-08-30  5:58   ` Greg KH [this message]
2017-08-29 20:36 ` Dan Carpenter
  -- strict thread matches above, loose matches on Subject: below --
2017-08-29 18:00 harsha
2017-08-29 18:07 ` Greg KH
2017-08-29 17:19 harsha
2017-08-29 17:28 ` Greg KH
2017-09-01  9:07 ` kbuild test robot
2017-09-01  9:11 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170830055814.GA2458@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=harshasharmaiitr@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.