From: Peter Zijlstra <peterz@infradead.org>
To: Byungchul Park <byungchul.park@lge.com>
Cc: Byungchul Park <max.byungchul.park@gmail.com>,
Tejun Heo <tj@kernel.org>,
johannes.berg@intel.com, Ingo Molnar <mingo@kernel.org>,
tglx@linutronix.de,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel-team@lge.com
Subject: Re: [RFC] workqueue: remove manual lockdep uses to detect deadlocks
Date: Wed, 30 Aug 2017 08:23:47 +0200 [thread overview]
Message-ID: <20170830062347.GI32112@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20170830015338.GD3240@X58A-UD3R>
On Wed, Aug 30, 2017 at 10:53:39AM +0900, Byungchul Park wrote:
> On Tue, Aug 29, 2017 at 08:57:27PM +0200, Peter Zijlstra wrote:
> > On Sat, Aug 26, 2017 at 12:49:26AM +0900, Byungchul Park wrote:
> > > > However, how would it distinguish things like flushing another work
> > >
> > > I think it must be distinguished with what it actually waits for, e.i.
> > > completion
> > > variables instead of work or wq. I will make it next week and let you know.
> >
> > So no. The existing annotations are strictly better than relying on
> > cross-release.
>
> Thank you for exaplanation but, as I already said, this is why I said
> "I don't think it's the same level currently. But, I can make it with
> some modification." to TJ:
>
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1479560.html
>
> And also I mentioned we might need the current code inevitably but, the
> existing annotations are never good and why here:
>
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1480173.html
I can read the words, but have no idea what you're trying to say.
next prev parent reply other threads:[~2017-08-30 6:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 8:41 [RFC] workqueue: remove manual lockdep uses to detect deadlocks Byungchul Park
2017-08-25 8:52 ` Byungchul Park
2017-08-25 13:34 ` Tejun Heo
2017-08-25 15:49 ` Byungchul Park
2017-08-29 18:57 ` Peter Zijlstra
2017-08-30 1:53 ` Byungchul Park
2017-08-30 6:23 ` Peter Zijlstra [this message]
2017-08-29 0:23 ` Byungchul Park
2017-08-28 6:55 ` Peter Zijlstra
2017-08-28 10:53 ` Byungchul Park
2017-08-29 0:55 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830062347.GI32112@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=byungchul.park@lge.com \
--cc=johannes.berg@intel.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=max.byungchul.park@gmail.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.