From: hch@lst.de (Christoph Hellwig)
Subject: [PATCHv2 1/4] nvme: factor metadata handling out of __nvme_submit_user_cmd
Date: Wed, 30 Aug 2017 10:14:43 +0200 [thread overview]
Message-ID: <20170830081443.GA17819@lst.de> (raw)
In-Reply-To: <d885cc92-38e0-5f61-9b1e-5cd0fdd40d32@mellanox.com>
> did we move the kfree(meta) here in porpose ?
> I think we'll leak in the "write" case.
Oops, my fault.
> In general, I prefer allocating and freeing the meta buffer in the same
> function but maybe it make sense to act otherwise here.
Think of nvme_add_user_metadata as the memory allocator, given
that it returns the buffer :)
next prev parent reply other threads:[~2017-08-30 8:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 21:46 [PATCHv2 0/4] nvme user metadata updates Keith Busch
2017-08-29 21:46 ` [PATCHv2 1/4] nvme: factor metadata handling out of __nvme_submit_user_cmd Keith Busch
2017-08-29 22:20 ` Max Gurtovoy
2017-08-29 22:39 ` Keith Busch
2017-08-30 8:14 ` Christoph Hellwig [this message]
2017-08-29 21:46 ` [PATCHv2 2/4] nvme/pci: Use req_op to determine DIF remapping Keith Busch
2017-08-29 22:29 ` Max Gurtovoy
2017-08-30 8:15 ` Christoph Hellwig
2017-08-29 21:46 ` [PATCHv2 3/4] nvme: Make nvme user functions static Keith Busch
2017-08-29 22:30 ` Max Gurtovoy
2017-08-29 21:46 ` [PATCHv2 4/4] nvme: Use metadata for passthrough commands Keith Busch
2017-08-29 22:31 ` Max Gurtovoy
2017-08-30 8:15 ` [PATCHv2 0/4] nvme user metadata updates Christoph Hellwig
2017-08-30 10:06 ` Sagi Grimberg
2017-08-30 12:53 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830081443.GA17819@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.