From: Olaf Hering <olaf@aepfle.de>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v6 3/3] tools/libxc: use superpages during restore of HVM guest
Date: Wed, 30 Aug 2017 16:27:19 +0200 [thread overview]
Message-ID: <20170830142719.GB31711@aepfle.de> (raw)
In-Reply-To: <20170830134839.liz6uo56ejjw2bsp@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 669 bytes --]
On Wed, Aug 30, Wei Liu wrote:
> As far as I can tell the algorithm in the patch can't handle:
>
> 1. First pfn in a batch points to start of second 1G address space
> 2. Second pfn in a batch points to a page in the middle of first 1G
> 3. Guest can only use 1G ram
In which way does it not handle it? Over-allocation is supposed to be
handled by the "ctx->restore.tot_pages + sp->count >
ctx->restore.max_pages" checks. Do you mean the second 1G is allocated,
then max_pages is reached, and allocation in other areas is not possible
anymore?
Can this actually happen with the available senders? If not, this is
again the missing memory map.
Olaf
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-30 14:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-26 10:33 [PATCH v6 0/3] tools/libxc: use superpages Olaf Hering
2017-08-26 10:33 ` [PATCH v6 1/3] tools/libxc: move SUPERPAGE macros to common header Olaf Hering
2017-08-26 10:33 ` [PATCH v6 2/3] tools/libxc: add API for bitmap access for restore Olaf Hering
2017-08-26 10:33 ` [PATCH v6 3/3] tools/libxc: use superpages during restore of HVM guest Olaf Hering
2017-08-29 9:58 ` Olaf Hering
2017-08-30 13:48 ` Wei Liu
2017-08-30 14:27 ` Olaf Hering [this message]
2017-08-30 15:14 ` Wei Liu
2017-08-30 15:53 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830142719.GB31711@aepfle.de \
--to=olaf@aepfle.de \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.