From: Thierry Reding <thierry.reding@gmail.com>
To: Derek Basehore <dbasehore@chromium.org>
Cc: linux-kernel@vger.kernel.org, jingoohan1@gmail.com,
lee.jones@linaro.org, briannorris@chromium.org,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH v2] pwm_bl: Fix overflow condition
Date: Wed, 30 Aug 2017 16:27:41 +0200 [thread overview]
Message-ID: <20170830142741.GD1361@ulmo> (raw)
In-Reply-To: <20170829203434.6826-1-dbasehore@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
On Tue, Aug 29, 2017 at 01:34:34PM -0700, Derek Basehore wrote:
> This fixes an overflow condition that can happen with high max
> brightness and period values in compute_duty_cycle. This fixes it by
> using a 64 bit variable for computing the duty cycle.
>
> Signed-off-by: Derek Basehore <dbasehore@chromium.org>
> ---
> drivers/video/backlight/pwm_bl.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
I'm still confused by the brightness-levels-scale comment in the other
thread, but this looks like a good fix for a potential overflow so:
Acked-by: Thierry Reding <thierry.reding@gmail.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-30 14:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 20:34 [PATCH v2] pwm_bl: Fix overflow condition Derek Basehore
2017-08-29 20:46 ` Brian Norris
2017-08-30 14:27 ` Thierry Reding [this message]
2017-08-30 16:26 ` Brian Norris
2017-09-04 15:16 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2017-08-29 20:40 Derek Basehore
2017-08-29 20:42 ` dbasehore .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830142741.GD1361@ulmo \
--to=thierry.reding@gmail.com \
--cc=briannorris@chromium.org \
--cc=dbasehore@chromium.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.