From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [0/7] EDAC, mce_amd: Issue decoded MCE through the tracepoint From: mark gross Message-Id: <20170830214719.GC103314@mtgdev> Date: Wed, 30 Aug 2017 14:47:19 -0700 To: Borislav Petkov Cc: Tony Luck , linux-edac , Steven Rostedt , Yazen Ghannam , X86 ML , LKML , Mauro Carvalho Chehab List-ID: T24gV2VkLCBBdWcgMzAsIDIwMTcgYXQgMDE6NDg6NDNQTSArMDIwMCwgQm9yaXNsYXYgUGV0a292 IHdyb3RlOgo+IEJ0dywKPiAKPiBob3cgYWJvdXQgY29tbXVuaWNhdGluZyBzdHVmZiB0byB0aGUg dXNlcnNwYWNlIGRhZW1vbiBsaWtlIHRoaXM/Cj4gCj4gVGhpcydsbCBzaW1wbGlmeSBhIGxvdCBv ZiBkZXRlY3Rpb24gaW4gdXNlcnNwYWNlLgo+IAo+IFRob3VnaHRzPwo+IAo+IC0tLQo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL3Jhcy9kZWJ1Z2ZzLmMgYi9kcml2ZXJzL3Jhcy9kZWJ1Z2ZzLmMKPiBp bmRleCA1MDE2MDMwNTdkZmYuLjYyZDNkYTlkMjU2ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3Jh cy9kZWJ1Z2ZzLmMKPiArKysgYi9kcml2ZXJzL3Jhcy9kZWJ1Z2ZzLmMKPiBAQCAtMSw1ICsxLDcg QEAKPiAgI2luY2x1ZGUgPGxpbnV4L2RlYnVnZnMuaD4KPiAgCj4gKyNpbmNsdWRlICIuLi8uLi9h cmNoL3g4Ni9rZXJuZWwvY3B1L21jaGVjay9tY2UtaW50ZXJuYWwuaCIKRldJVyBJIHRoaXMgbG9v a3MgZmlzaHkgaW4gYXJjaCBpbmRlcGVuZGVudCBjb2RlLgpJIGFzc3VtZSB0aGlzIGluY2x1ZGUg aXMgZm9yIHRoZSBkZWZpbml0aW9uIG9mIHRoZSBtY2FfY2ZnIGdsb2JhbCB1c2VkIGluIHRoZQpw cmludGYgYmVsb3cuIAoKCj4gKwo+ICBzdHJ1Y3QgZGVudHJ5ICpyYXNfZGVidWdmc19kaXI7Cj4g IAo+ICBzdGF0aWMgYXRvbWljX3QgdHJhY2VfY291bnQgPSBBVE9NSUNfSU5JVCgwKTsKPiBAQCAt MTIsNyArMTQsOSBAQCBFWFBPUlRfU1lNQk9MX0dQTChyYXNfdXNlcnNwYWNlX2NvbnN1bWVycyk7 Cj4gIAo+ICBzdGF0aWMgaW50IHRyYWNlX3Nob3coc3RydWN0IHNlcV9maWxlICptLCB2b2lkICp2 KQo+ICB7Cj4gLQlyZXR1cm4gYXRvbWljX3JlYWQoJnRyYWNlX2NvdW50KTsKPiArCXNlcV9wcmlu dGYobSwgInJlYWRlcnM6JWRcbiIsIGF0b21pY19yZWFkKCZ0cmFjZV9jb3VudCkpOwo+ICsJc2Vx X3ByaW50ZihtLCAiaGFzIGRlY29kZXI6JWRcbiIsIG1jYV9jZmcuaGFzX2RlY29kZXIpOwoKZG8g eW91IHdhbnQgdG8gd29ycnkgYWJvdXQgdGhpcyBkZWJ1Z2ZzIGludGVyZmFjZXMgYXMgQUJJPwpk ZWJ1Z2ZzIGNoYW5nZXMgaGF2ZSBiaXR0ZW4gbWUgb24gb25lIHNwZWNpZmljIE9TIGluIGlycml0 YXRpbmcgd2F5cy4KCkknbSBub3Qgc3VyZSB3aGF0IHRoZSB3b3JkIGlzIGZvciBkZWJ1Z2ZzIGlu dGVyZmFjZXMgYXMgQUJJIHRoZXNlIGRheXMgc28gdGhpcwpmZWVkYmFjayBtYXkgYmUgbm90IHNv IHVzZWZ1bC4KCi0tbWFyawoKPiArCXJldHVybiAwOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IHRy YWNlX29wZW4oc3RydWN0IGlub2RlICppbm9kZSwgc3RydWN0IGZpbGUgKmZpbGUpCj4gCj4gLS0g Cj4gUmVnYXJkcy9HcnVzcywKPiAgICAgQm9yaXMuCj4gCj4gR29vZCBtYWlsaW5nIHByYWN0aWNl cyBmb3IgNDAwOiBhdm9pZCB0b3AtcG9zdGluZyBhbmQgdHJpbSB0aGUgcmVwbHkuCj4gLS0KPiBU byB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUg bGludXgtZWRhYyIgaW4KPiB0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIu a2VybmVsLm9yZwo+IE1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5v cmcvbWFqb3Jkb21vLWluZm8uaHRtbAotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6 IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LWVkYWMiIGluCnRoZSBib2R5IG9mIGEg bWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8g YXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751033AbdH3VrW (ORCPT ); Wed, 30 Aug 2017 17:47:22 -0400 Received: from mga02.intel.com ([134.134.136.20]:23401 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbdH3VrV (ORCPT ); Wed, 30 Aug 2017 17:47:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,450,1498546800"; d="scan'208";a="145829215" Date: Wed, 30 Aug 2017 14:47:19 -0700 From: mark gross To: Borislav Petkov Cc: Tony Luck , linux-edac , Steven Rostedt , Yazen Ghannam , X86 ML , LKML , Mauro Carvalho Chehab Subject: Re: [PATCH 0/7] EDAC, mce_amd: Issue decoded MCE through the tracepoint Message-ID: <20170830214719.GC103314@mtgdev> Reply-To: mgross@linux.intel.com References: <20170825102411.8682-1-bp@alien8.de> <20170828134549.wh6toneoca47ff2w@pd.tnic> <20170830114843.deetnlz2wjbgbaj4@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170830114843.deetnlz2wjbgbaj4@pd.tnic> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 30, 2017 at 01:48:43PM +0200, Borislav Petkov wrote: > Btw, > > how about communicating stuff to the userspace daemon like this? > > This'll simplify a lot of detection in userspace. > > Thoughts? > > --- > diff --git a/drivers/ras/debugfs.c b/drivers/ras/debugfs.c > index 501603057dff..62d3da9d256f 100644 > --- a/drivers/ras/debugfs.c > +++ b/drivers/ras/debugfs.c > @@ -1,5 +1,7 @@ > #include > > +#include "../../arch/x86/kernel/cpu/mcheck/mce-internal.h" FWIW I this looks fishy in arch independent code. I assume this include is for the definition of the mca_cfg global used in the printf below. > + > struct dentry *ras_debugfs_dir; > > static atomic_t trace_count = ATOMIC_INIT(0); > @@ -12,7 +14,9 @@ EXPORT_SYMBOL_GPL(ras_userspace_consumers); > > static int trace_show(struct seq_file *m, void *v) > { > - return atomic_read(&trace_count); > + seq_printf(m, "readers:%d\n", atomic_read(&trace_count)); > + seq_printf(m, "has decoder:%d\n", mca_cfg.has_decoder); do you want to worry about this debugfs interfaces as ABI? debugfs changes have bitten me on one specific OS in irritating ways. I'm not sure what the word is for debugfs interfaces as ABI these days so this feedback may be not so useful. --mark > + return 0; > } > > static int trace_open(struct inode *inode, struct file *file) > > -- > Regards/Gruss, > Boris. > > Good mailing practices for 400: avoid top-posting and trim the reply. > -- > To unsubscribe from this list: send the line "unsubscribe linux-edac" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html