From: daniel.verkamp@intel.com (Daniel Verkamp)
Subject: [PATCH] nvme-cli: generate spec-compliant UUID NQNs
Date: Wed, 30 Aug 2017 15:25:16 -0700 [thread overview]
Message-ID: <20170830222516.44089-1-daniel.verkamp@intel.com> (raw)
The gen-hostnqn command previously generated UUID NQNs in a format that
does not match the NVMe specification.
Signed-off-by: Daniel Verkamp <daniel.verkamp at intel.com>
---
Documentation/nvme-gen-hostnqn.txt | 2 +-
nvme.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/nvme-gen-hostnqn.txt b/Documentation/nvme-gen-hostnqn.txt
index 6d5346f..9efefb5 100644
--- a/Documentation/nvme-gen-hostnqn.txt
+++ b/Documentation/nvme-gen-hostnqn.txt
@@ -13,7 +13,7 @@ SYNOPSIS
DESCRIPTION
-----------
Generate a random host NQN in the form:
-nqn.2014-08.org.nvmexpress:NVMf:uuid:1b4e28ba-2fa1-11d2-883f-0016d3cca427
+nqn.2014-08.org.nvmexpress:uuid:1b4e28ba-2fa1-11d2-883f-0016d3cca427
and prints it to stdout.
OPTIONS
diff --git a/nvme.c b/nvme.c
index 676e8bf..f1d6d65 100644
--- a/nvme.c
+++ b/nvme.c
@@ -3217,7 +3217,7 @@ static int gen_hostnqn_cmd(int argc, char **argv, struct command *command, struc
uuid_generate_random(uuid);
uuid_unparse_lower(uuid, uuid_str);
- printf("nqn.2014-08.org.nvmexpress:NVMf:uuid:%s\n", uuid_str);
+ printf("nqn.2014-08.org.nvmexpress:uuid:%s\n", uuid_str);
return 0;
}
#else
--
2.13.5
next reply other threads:[~2017-08-30 22:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 22:25 Daniel Verkamp [this message]
2017-08-31 9:14 ` [PATCH] nvme-cli: generate spec-compliant UUID NQNs Christoph Hellwig
2017-08-31 17:06 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830222516.44089-1-daniel.verkamp@intel.com \
--to=daniel.verkamp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.