From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 31 Aug 2017 13:10:49 +0200 Subject: [Buildroot] [PATCH] package/xmlstarlet: fix host build In-Reply-To: References: <20170830224010.15658-1-romain.naour@gmail.com> <20170831091419.3d0039cc@windsurf.lan> <20170831093921.11448124@windsurf.lan> Message-ID: <20170831131049.5541217e@windsurf.lan> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Thu, 31 Aug 2017 12:51:24 +0200, Romain Naour wrote: > Well, gmail app on my phone... Gaah, horrible (again with this e-mail). > Libxml-dev wasn't installed on my host. > I'll take a look later today. > > Btw, host-xmlstarlet is a dependendy of kodi package which depends on java > installed on the host. > > Maybe host-xmlstarlet is never build on the autobuiders ? > > Can you try to build it ? It builds fine on my autobuilder: >>> host-xmlstarlet 1.6.1 Building PATH="/home/test/foo/host/bin:/home/test/foo/host/sbin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games" PKG_CONFIG="/home/test/foo/host/bin/pkg-config" PKG_CONFIG_SYSROOT_DIR="/" PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 PKG_CONFIG_LIBDIR="/home/test/foo/host/lib/pkgconfig:/home/test/foo/host/share/pkgconfig" /usr/bin/make -j9 -C /home/test/foo/build/host-xmlstarlet-1.6.1/ /usr/bin/make all-am GEN src/usage.c GEN src/c14n-usage.c GEN src/depyx-usage.c GEN src/edit-usage.c GEN src/elem-usage.c GEN src/escape-usage.c GEN src/format-usage.c GEN src/ls-usage.c GEN src/pyx-usage.c GEN src/select-usage.c GEN src/trans-usage.c GEN src/unescape-usage.c GEN src/validate-usage.c CC src/trans.o CC src/xml.o CC src/xml_C14N.o CC src/xml_depyx.o CC src/xml_edit.o CC src/xml_elem.o CC src/xml_escape.o CC src/xml_format.o CC src/xml_ls.o src/xml_edit.c: In function 'edInsert': src/xml_edit.c:371:27: warning: 'node' may be used uninitialized in this function [-Wmaybe-uninitialized] CC src/xml_pyx.o CC src/xml_select.o CC src/xml_trans.o CC src/xml_validate.o CC src/usage.o CC src/c14n-usage.o CC src/depyx-usage.o CC src/edit-usage.o CC src/elem-usage.o src/xml_select.c: In function 'selPrepareXslt': src/xml_select.c:552:17: warning: pointer targets in passing argument 3 of 'xmlStrPrintf' differ in signedness [-Wpointer-sign] In file included from /home/test/foo/host/include/libxml2/libxml/tree.h:18:0, from src/xml_select.c:38: /home/test/foo/host/include/libxml2/libxml/xmlstring.h:98:17: note: expected 'const char *' but argument is of type 'xmlChar *' CC src/escape-usage.o CC src/format-usage.o CC src/ls-usage.o CC src/pyx-usage.o CC src/select-usage.o CC src/trans-usage.o CC src/unescape-usage.o CC src/validate-usage.o CCLD xml >>> host-xmlstarlet 1.6.1 Installing to host directory PATH="/home/test/foo/host/bin:/home/test/foo/host/sbin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games" PKG_CONFIG="/home/test/foo/host/bin/pkg-config" PKG_CONFIG_SYSROOT_DIR="/" PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 PKG_CONFIG_LIBDIR="/home/test/foo/host/lib/pkgconfig:/home/test/foo/host/share/pkgconfig" /usr/bin/make -j9 install -C /home/test/foo/build/host-xmlstarlet-1.6.1/ /bin/mkdir -p '/home/test/foo/host/share/doc/xmlstarlet' /bin/mkdir -p '/home/test/foo/host/share/man/man1' /usr/bin/install -c -m 644 doc/xmlstarlet-ug.html doc/html.css doc/xmlstarlet.txt '/home/test/foo/host/share/doc/xmlstarlet' /usr/bin/install -c -m 644 doc/xmlstarlet.1 '/home/test/foo/host/share/man/man1' /bin/mkdir -p '/home/test/foo/host/bin' /usr/bin/install -c xml '/home/test/foo/host/bin' It detects libxml and libxslt in $(HOST_DIR), according to the configure script: checking for xml2-config... /home/test/foo/host/bin/xml2-config configure: using libxml-2.9.4 checking for xslt-config... /home/test/foo/host/bin/xslt-config configure: using libxslt-1.1.29 Indeed $(HOST_DIR)/bin is before /usr/bin in the PATH so it uses the Buildroot-built libraries. Could you investigate a little bit more what's going on in your case? I believe your patch is OK, but I'd feel more comfortable with a more solid explanation. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com