From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH v1 3/4] KVM: s390: vsie: cleanup mcck reinjection Date: Thu, 31 Aug 2017 13:11:56 +0200 Message-ID: <20170831131156.5d7c3d79.cohuck@redhat.com> References: <20170830160603.5452-1-david@redhat.com> <20170830160603.5452-4-david@redhat.com> <93ab3b20-beca-3adb-f272-eeee8c87d799@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: David Hildenbrand , kvm@vger.kernel.org, Paolo Bonzini , Radim =?UTF-8?B?S3LEjW3DocWZ?= To: Christian Borntraeger Return-path: Received: from mx1.redhat.com ([209.132.183.28]:57920 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750790AbdHaLMB (ORCPT ); Thu, 31 Aug 2017 07:12:01 -0400 In-Reply-To: <93ab3b20-beca-3adb-f272-eeee8c87d799@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 31 Aug 2017 13:01:39 +0200 Christian Borntraeger wrote: > Reviewed-by: Christian Borntraeger > > I will add some patch description like: > > We already know that the machine check information was part of the vsie_page. Shorten that to "The machine check information is part of the vsie_page."? In any case, Reviewed-by: Cornelia Huck > > applied. > > On 08/30/2017 06:06 PM, David Hildenbrand wrote: > > Signed-off-by: David Hildenbrand > > --- > > arch/s390/kvm/vsie.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c > > index 715c19c45d9a..b5eec30eb37d 100644 > > --- a/arch/s390/kvm/vsie.c > > +++ b/arch/s390/kvm/vsie.c > > @@ -806,8 +806,6 @@ static int do_vsie_run(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page) > > { > > struct kvm_s390_sie_block *scb_s = &vsie_page->scb_s; > > struct kvm_s390_sie_block *scb_o = vsie_page->scb_o; > > - struct mcck_volatile_info *mcck_info; > > - struct sie_page *sie_page; > > int rc; > > > > handle_last_fault(vcpu, vsie_page); > > @@ -831,9 +829,7 @@ static int do_vsie_run(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page) > > > > if (rc == -EINTR) { > > VCPU_EVENT(vcpu, 3, "%s", "machine check"); > > - sie_page = container_of(scb_s, struct sie_page, sie_block); > > - mcck_info = &sie_page->mcck_info; > > - kvm_s390_reinject_machine_check(vcpu, mcck_info); > > + kvm_s390_reinject_machine_check(vcpu, &vsie_page->mcck_info); > > return 0; > > } > > >