From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnPSb-0006gt-QJ for qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:24:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnPSX-00042P-Ru for qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:24:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49970) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dnPSX-00042G-LX for qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:24:37 -0400 Date: Thu, 31 Aug 2017 15:24:33 +0200 From: Cornelia Huck Message-ID: <20170831152433.0394264e.cohuck@redhat.com> In-Reply-To: <20170831121828.85885-1-pasic@linux.vnet.ibm.com> References: <20170831121828.85885-1-pasic@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] s390x/css: fix cc handling for XSCH List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Halil Pasic Cc: Dong Jia Shi , Pierre Morel , Thomas Huth , qemu-devel@nongnu.org On Thu, 31 Aug 2017 14:18:28 +0200 Halil Pasic wrote: > The function ioinst_handle_xsch is presenting cc 2 when it's supposed to > present cc 1 and the other way around, because css_do_xsch has the error > codes mixed up. Because cc 1 has precedence over cc 2 we also have to > swap the two checks. > > Let us fix this. > > Signed-off-by: Halil Pasic > Reported-by: Pierre Morel > --- > > Was previously a part of a series (due to an accident the > series had no name). This version also fixes the priority > (aka precedence) problem. > > --- > hw/s390x/css.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Thanks, applied.