From: Jens Axboe <axboe@kernel.dk>
To: Scott Bauer <scott.bauer@intel.com>
Cc: linux-block@vger.kernel.org, jonathan.derrick@intel.com,
david.fugate@intel.com, hch@infradead.org,
rafael.antognolli@intel.com
Subject: Re: [PATCH] block: sed-opal: Set MBRDone on S3 resume path if TPER is MBREnabled
Date: Thu, 31 Aug 2017 14:19:44 -0600 [thread overview]
Message-ID: <20170831201942.GA18975@kernel.dk> (raw)
In-Reply-To: <20170831174238.2714-1-scott.bauer@intel.com>
On Thu, Aug 31 2017, Scott Bauer wrote:
> @@ -2345,6 +2371,11 @@ bool opal_unlock_from_suspend(struct opal_dev *dev)
> suspend->unlk.session.sum);
> was_failure = true;
> }
> + if (dev->mbr_enabled) {
> + ret = __opal_set_mbr_done(dev, &suspend->unlk.session.opal_key);
> + if (ret)
> + pr_debug("Failed to set MBR Done in S3 resume\n");
> + }
Should ret != 0 set was_failure = true here?
--
Jens Axboe
next prev parent reply other threads:[~2017-08-31 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 17:42 [PATCH] block: sed-opal: Set MBRDone on S3 resume path if TPER is MBREnabled Scott Bauer
2017-08-31 20:10 ` Jon Derrick
2017-08-31 19:58 ` Scott Bauer
2017-09-01 7:31 ` Christoph Hellwig
2017-08-31 20:19 ` Jens Axboe [this message]
2017-08-31 20:13 ` Scott Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831201942.GA18975@kernel.dk \
--to=axboe@kernel.dk \
--cc=david.fugate@intel.com \
--cc=hch@infradead.org \
--cc=jonathan.derrick@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=rafael.antognolli@intel.com \
--cc=scott.bauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.