All of lore.kernel.org
 help / color / mirror / Atom feed
From: weiping zhang <zhangweiping@didichuxing.com>
To: <viro@zeniv.linux.org.uk>
Cc: <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH RFC v3] fs: Avoid create file when open() with O_DIRECT if fs not support
Date: Fri, 1 Sep 2017 09:36:53 +0800	[thread overview]
Message-ID: <20170901013653.GA30611@localhost.didichuxing.com> (raw)
In-Reply-To: <20170828130719.GA11360@localhost.didichuxing.com>

On Mon, Aug 28, 2017 at 09:07:27PM +0800, weiping zhang wrote:
> Some filesystems not support O_DIRECT, when user open with O_DIRECT ,
> an errno -EINVAL return to userspace by open_check_o_direct, but the
> file has been created, it's a strange thing. Add a checking for that
> can avoid creating file if fs not support O_DIRECT.
> 

Hi AI,

would you please give some comments for this patch,

---
v2 -> v3:
introduce a new function for checking inode support direct io or not.

v1 -> v2:
a common way checking if fs support direct io, no matter what
underlaying filesystem is.

Thanks

      reply	other threads:[~2017-09-01  1:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-28 13:07 [PATCH RFC v3] fs: Avoid create file when open() with O_DIRECT if fs not support weiping zhang
2017-09-01  1:36 ` weiping zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170901013653.GA30611@localhost.didichuxing.com \
    --to=zhangweiping@didichuxing.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.