From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59706) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnkB2-0001HS-4L for qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:31:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnkAx-0006wn-2H for qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:31:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50734) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dnkAw-0006wY-SG for qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:31:50 -0400 Date: Fri, 1 Sep 2017 19:31:47 +0800 From: Fam Zheng Message-ID: <20170901113147.GA5015@lemon.lan> References: <1504250391-6353-1-git-send-email-thuth@redhat.com> <150425055972.204.8095890686679875127@b5667b65043c> <20170901092845.GF31680@redhat.com> <7149d2ad-2f4f-8b1a-496c-22b8a05e43d4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7149d2ad-2f4f-8b1a-496c-22b8a05e43d4@redhat.com> Subject: Re: [Qemu-devel] [qemu-web PATCH] Add a blog post about the release of version 2.10.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: "Daniel P. Berrange" , qemu-devel@nongnu.org, pbonzini@redhat.com, mdroth@linux.vnet.ibm.com On Fri, 09/01 12:41, Thomas Huth wrote: > On 01.09.2017 11:28, Daniel P. Berrange wrote: > > On Fri, Sep 01, 2017 at 12:22:41AM -0700, no-reply@patchew.org wrote: > >> Hi, > >> > >> This series seems to have some coding style problems. See output below for > >> more information: > >> > >> Message-id: 1504250391-6353-1-git-send-email-thuth@redhat.com > >> Subject: [Qemu-devel] [qemu-web PATCH] Add a blog post about the release of version 2.10.0 > >> Type: series > >> > >> === TEST SCRIPT BEGIN === > >> #!/bin/bash > >> > >> BASE=base > >> n=1 > >> total=$(git log --oneline $BASE.. | wc -l) > >> failed=0 > >> > >> git config --local diff.renamelimit 0 > >> git config --local diff.renames True > >> > >> commits="$(git log --format=%H --reverse $BASE..)" > >> for c in $commits; do > >> echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > >> if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then > >> failed=1 > >> echo > >> fi > >> n=$((n+1)) > >> done > >> > >> exit $failed > >> === TEST SCRIPT END === > >> > >> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > >> From https://github.com/patchew-project/qemu > >> * [new tag] patchew/1504250391-6353-1-git-send-email-thuth@redhat.com -> patchew/1504250391-6353-1-git-send-email-thuth@redhat.com > >> Switched to a new branch 'test' > >> b70b83ae5d Add a blog post about the release of version 2.10.0 > >> > >> === OUTPUT BEGIN === > >> Checking PATCH 1/1: Add a blog post about the release of version 2.10.0... > >> ERROR: trailing whitespace > >> #60: FILE: _posts/2017-09-01-qemu-2-10-0.md:43: > >> + * s390: support for z14 CPU models and netboot/TFTP via CCW BIOS, $ > >> > >> total: 1 errors, 0 warnings, 56 lines checked > > > > While it is nice that it identified the trailing whitespace in this > > case, does it really make sense for the patchew to be running the > > checkpatch.pl from qemu.git, against patches to qemu-web.git ? > > > > Perhaps it should skip patches with 'web' or 'qemu-web' in the > > [...] part of the subject ? > > +1 Will try to find time working on this in the weekend. Fam