From: Wei Liu <wei.liu2@citrix.com>
To: Yi Sun <yi.y.sun@linux.intel.com>
Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com,
wei.liu2@citrix.com, roger.pau@citrix.com
Subject: Re: [PATCH] tools: change the type of '*nr' in 'libxl_psr_cat_get_info'
Date: Fri, 1 Sep 2017 16:43:34 +0100 [thread overview]
Message-ID: <20170901154334.cuhq6jntlme2dkoc@citrix.com> (raw)
In-Reply-To: <1504249163-27185-1-git-send-email-yi.y.sun@linux.intel.com>
On Fri, Sep 01, 2017 at 02:59:23PM +0800, Yi Sun wrote:
> Due to historical reason, type of parameter '*nr' in 'libxl_psr_cat_get_info'
> is 'int'. But this is not right. It should be 'unsigned int'. This patch fixes
> this and does related changes.
>
> Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
> Signed-off-by: Yi Sun <yi.y.sun@linux.intel.com>
Please say in the commit message that this is OK because the function in
question is never released.
Otherwise you need to define a LIBXL_HAVE
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-01 15:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 8:08 [PATCH 2/2] tools: remove unnecessary PSR macros Yi Sun
2017-08-31 9:07 ` Roger Pau Monné
2017-09-01 6:59 ` [PATCH] tools: change the type of '*nr' in 'libxl_psr_cat_get_info' Yi Sun
2017-09-01 9:07 ` Roger Pau Monné
2017-09-01 15:43 ` Wei Liu [this message]
2017-09-01 12:15 ` [PATCH v2] " Yi Sun
2017-09-01 14:33 ` Roger Pau Monné
2017-09-01 15:50 ` Wei Liu
2017-09-02 15:01 ` Yi Sun
2017-09-04 9:08 ` Wei Liu
2017-09-01 15:42 ` [PATCH 2/2] tools: remove unnecessary PSR macros Wei Liu
2017-09-04 3:25 ` Yi Sun
2017-09-04 3:08 ` [PATCH v2] " Yi Sun
2017-09-04 8:49 ` Wei Liu
2017-09-04 9:10 ` Yi Sun
2017-09-04 9:13 ` Wei Liu
2017-09-04 9:14 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901154334.cuhq6jntlme2dkoc@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=yi.y.sun@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.