From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs <linux-xfs@vger.kernel.org>,
Brian Foster <bfoster@redhat.com>,
Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH v2] xfs: fix compiler warnings
Date: Fri, 1 Sep 2017 08:54:53 -0700 [thread overview]
Message-ID: <20170901155453.GZ3775@magnolia> (raw)
In-Reply-To: <20170901081005.GB32746@infradead.org>
On Fri, Sep 01, 2017 at 01:10:05AM -0700, Christoph Hellwig wrote:
> Can we please just ensure ASSERT always evaluates the argument,
> similar to BUG()?
Assuming you meant BUG_ON or something that actually takes a parameter,
yes you can do that, though now we have to fix up a bunch of things like
the xfs_trans debug counter asserts and anything that asserts on
xfs_isilocked.
-.text 785555 0
+.text 787843 0
I guess that's only 0.29% larger...
--D
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-09-01 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 23:38 [PATCH v2] xfs: fix compiler warnings Darrick J. Wong
2017-09-01 0:29 ` Dave Chinner
2017-09-01 8:10 ` Christoph Hellwig
2017-09-01 15:54 ` Darrick J. Wong [this message]
2017-09-01 10:26 ` Brian Foster
2017-09-01 16:19 ` Darrick J. Wong
2017-09-01 16:29 ` Brian Foster
2017-09-01 16:33 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901155453.GZ3775@magnolia \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.