From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Brian Foster <bfoster@redhat.com>,
xfs <linux-xfs@vger.kernel.org>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH v2] xfs: don't set v3 xflags for v2 inodes
Date: Fri, 1 Sep 2017 12:29:58 -0700 [thread overview]
Message-ID: <20170901192958.GA30923@infradead.org> (raw)
In-Reply-To: <20170901175223.GH3775@magnolia>
On Fri, Sep 01, 2017 at 10:52:23AM -0700, Darrick J. Wong wrote:
> > {
> > - unsigned int di_flags;
> > - uint64_t di_flags2;
> > -
> > /* can't set PREALLOC this way, just preserve it */
> > - di_flags = (ip->i_d.di_flags & XFS_DIFLAG_PREALLOC);
> > + unsigned int di_flags =
> > + (ip->i_d.di_flags & XFS_DIFLAG_PREALLOC);
>
> ip->i_d.di_flags is uint16_t, so di_flags ought to match, right?
The existing code uses unsigned int as seen above. But yes, it
could be fixed to be a uint16_t.
> Otherwise, I guess this looks ok, want to send it as a real patch?
Sure. Doing some quick QA runs and it will be out.
Note that I'll assume it'll be for a tree without the previous
patch, unlike current for-next..
next prev parent reply other threads:[~2017-09-01 19:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 15:55 [PATCH] xfs: don't set DAX flag for v2 inodes Darrick J. Wong
2017-08-30 16:15 ` Christoph Hellwig
2017-08-30 16:22 ` Darrick J. Wong
2017-08-30 16:38 ` [PATCH v2] xfs: don't set v3 xflags " Darrick J. Wong
2017-08-31 13:17 ` Christoph Hellwig
2017-08-31 13:34 ` Brian Foster
2017-08-31 14:06 ` Christoph Hellwig
2017-08-31 14:09 ` Christoph Hellwig
2017-08-31 14:17 ` Brian Foster
2017-08-31 19:57 ` Darrick J. Wong
2017-09-01 7:21 ` Christoph Hellwig
2017-09-01 17:52 ` Darrick J. Wong
2017-09-01 19:29 ` Christoph Hellwig [this message]
2017-09-01 19:40 ` Darrick J. Wong
2017-09-01 20:06 ` Darrick J. Wong
2017-09-01 20:08 ` Christoph Hellwig
2017-08-31 13:35 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901192958.GA30923@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.cz \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.