All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	vivien.didelot@savoirfairelinux.com, jiri@resnulli.us,
	jhs@mojatatu.com, xiyou.wangcong@gmail.com
Subject: Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Configure IMP port TC2QOS mapping
Date: Sat, 2 Sep 2017 18:30:57 +0200	[thread overview]
Message-ID: <20170902163057.GB5463@lunn.ch> (raw)
In-Reply-To: <1504310354-42773-5-git-send-email-f.fainelli@gmail.com>

> @@ -129,6 +130,14 @@ static void bcm_sf2_imp_setup(struct dsa_switch *ds, int port)
>  	reg |= MII_DUMB_FWDG_EN;
>  	core_writel(priv, reg, CORE_SWITCH_CTRL);
>  
> +	/* Configure Traffic Class to QoS mapping, allow each priority to map
> +	 * to a different queue number
> +	 */
> +	reg = core_readl(priv, CORE_PORT_TC2_QOS_MAP_PORT(port));
> +	for (i = 0; i < 8; i++)
> +		reg |= i << (PRT_TO_QID_SHIFT * i);

Hi Florian

Rather than 8, would ds->num_tx_queues be more descriptive?

       Andrew

  reply	other threads:[~2017-09-02 16:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-01 23:59 [PATCH net-next 0/4] net: dsa: Allow switch drivers to indicate number of TX queues Florian Fainelli
2017-09-01 23:59 ` [PATCH net-next 1/4] " Florian Fainelli
2017-09-01 23:59 ` [PATCH net-next 2/4] net: dsa: tag_brcm: Set output queue from skb queue mapping Florian Fainelli
2017-09-01 23:59 ` [PATCH net-next 3/4] net: dsa: bcm_sf2: Advertise number of egress queues Florian Fainelli
2017-09-01 23:59 ` [PATCH net-next 4/4] net: dsa: bcm_sf2: Configure IMP port TC2QOS mapping Florian Fainelli
2017-09-02 16:30   ` Andrew Lunn [this message]
2017-09-02 16:32     ` Florian Fainelli
2017-09-02 17:47       ` Andrew Lunn
2017-09-02 17:57         ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170902163057.GB5463@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.