All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] arch: add option to disable internal toolchain backend
Date: Sat, 2 Sep 2017 21:47:04 +0200	[thread overview]
Message-ID: <20170902214704.0a01ba92@windsurf.lan> (raw)
In-Reply-To: <5326fe3900e51f3b0a2ac4fc9d750245d560802c.1504381100.git.yann.morin.1998@free.fr>

Hello,

Thanks for working on this!

On Sat,  2 Sep 2017 21:38:49 +0200, Yann E. MORIN wrote:

> +# For some architectures or specific cores, our internal toolchain
> +# backend is not suitable (like, missing support in upstream gcc, or
> +# no ChipCo fork exists...)
> +config BR2_ARCH_NO_INTERNAL_BACKEND
> +	bool

I'm not a big fan of the option name. What about:

config BR2_ARCH_HAS_TOOLCHAIN_BUILDROOT
	bool
	default y if !BR2_ARCH_HAS_NO_TOOLCHAIN_BUILDROOT

config BR2_ARCH_HAS_NO_TOOLCHAIN_BUILDROOT
	bool

So, arches can select BR2_ARCH_HAS_NO_TOOLCHAIN_BUILDROOT, and else
we can "depends on BR2_ARCH_HAS_TOOLCHAIN_BUILDROOT".

> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index 584d053058..919757e558 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -43,6 +43,7 @@ choice
>  config BR2_TOOLCHAIN_BUILDROOT
>  	bool "Buildroot toolchain"
>  	select BR2_TOOLCHAIN_HAS_SHADOW_PASSWORDS
> +	depends on !BR2_ARCH_NO_INTERNAL_BACKEND
>  	depends on !BR2_bf606
>  	depends on !BR2_bf607
>  	depends on !BR2_bf608

Now that I think of it: we have dropped the Blackfin ADI external
toolchain. Therefore, we currently have no in-tree solution to use/test
bf606, bf607, bf608, etc. Perhaps we should drop them instead ?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-09-02 19:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-02 19:38 [Buildroot] [PATCH 0/4] arch: not all have support in the internal backend Yann E. MORIN
2017-09-02 19:38 ` [Buildroot] [PATCH 1/4] arch: add option to disable internal toolchain backend Yann E. MORIN
2017-09-02 19:47   ` Thomas Petazzoni [this message]
2017-09-02 20:10     ` Yann E. MORIN
2017-09-02 20:17       ` Thomas Petazzoni
2017-09-02 19:38 ` [Buildroot] [PATCH 2/4] arch/csky: internal backend not suitable Yann E. MORIN
2017-09-02 19:38 ` [Buildroot] [PATCH 3/4] arch/bfin: internal backend not suitable for some cores Yann E. MORIN
2017-09-02 19:48   ` Thomas Petazzoni
2017-09-02 20:01     ` Yann E. MORIN
2017-09-02 19:38 ` [Buildroot] [PATCH 4/4] arch/mips: " Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170902214704.0a01ba92@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.