All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/sysdig: fix missing curlbuild include
Date: Sat, 2 Sep 2017 23:17:28 +0200	[thread overview]
Message-ID: <20170902231728.2be2989f@windsurf.lan> (raw)
In-Reply-To: <1504281081-11201-1-git-send-email-angelo.compagnucci@gmail.com>

Hello,

On Fri,  1 Sep 2017 17:51:21 +0200, Angelo Compagnucci wrote:
> curlbuild.h was removed in recent versions of curl, backporting a
> patch from mainline to fix sysdig until a newer version is
> released.
> 
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>

Thanks a lot, looks good, except...

> ---
>  .../sysdig/0001-Don-t-include-curlbuild.h.patch    | 56 ++++++++++++++++++++++
>  1 file changed, 56 insertions(+)
>  create mode 100644 package/sysdig/0001-Don-t-include-curlbuild.h.patch
> 
> diff --git a/package/sysdig/0001-Don-t-include-curlbuild.h.patch b/package/sysdig/0001-Don-t-include-curlbuild.h.patch
> new file mode 100644
> index 0000000..ae406c0
> --- /dev/null
> +++ b/package/sysdig/0001-Don-t-include-curlbuild.h.patch
> @@ -0,0 +1,56 @@
> +From 8a6670ea4b57c0e2bf8588d4534b22d1ea860989 Mon Sep 17 00:00:00 2001
> +From: Mark Stemm <mark.stemm@gmail.com>
> +Date: Tue, 15 Aug 2017 17:49:53 -0700
> +Subject: [PATCH] Don't include curlbuild.h
> +
> +It's not required to build and it's not present with some newer versions
> +of libcurl, so removing it.
> +
> +Thanks to https://github.com/hhoffstaette for the tip.
> +
> +This fixes https://github.com/draios/sysdig/issues/895.

You must add your Signed-off-by here.

Could you resend with this fixed ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-09-02 21:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-01 15:51 [Buildroot] [PATCH] package/sysdig: fix missing curlbuild include Angelo Compagnucci
2017-09-02 21:17 ` Thomas Petazzoni [this message]
     [not found]   ` <CA+TH9Vkr+B6-1f0QUWP98UJxbnP+c-V=htKy9byKwF8-gzzZGA@mail.gmail.com>
2017-09-03  7:16     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170902231728.2be2989f@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.