From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753292AbdIDDT0 (ORCPT ); Sun, 3 Sep 2017 23:19:26 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34922 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753124AbdIDDTY (ORCPT ); Sun, 3 Sep 2017 23:19:24 -0400 Date: Sun, 03 Sep 2017 20:19:23 -0700 (PDT) Message-Id: <20170903.201923.1025438565183602962.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: dsa: loop: Do not unregister invalid fixed PHY From: David Miller In-Reply-To: <20170902155645.19071-1-f.fainelli@gmail.com> References: <20170902155645.19071-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 03 Sep 2017 20:19:24 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Sat, 2 Sep 2017 08:56:45 -0700 > During error injection it was possible to crash in dsa_loop_exit() because of > an attempt to unregister an invalid PHY. We actually want to the driver probing > in dsa_loop_init() even though fixed_phy_register() may return an error to > exercise how DSA deals with such cases, but we should not be crashing during > driver removal. > > Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver") > Signed-off-by: Florian Fainelli Applied and queued up for -stable, thanks.