From: "Daniel P. Berrange" <berrange@redhat.com>
To: Kashyap Chamarthy <kchamart@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, famz@redhat.com,
qemu-block@nongnu.org, dgilbert@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Make test 192 use QMP; convert it to Python
Date: Mon, 4 Sep 2017 15:48:12 +0100 [thread overview]
Message-ID: <20170904144812.GD27285@redhat.com> (raw)
In-Reply-To: <20170904111616.21333-1-kchamart@redhat.com>
On Mon, Sep 04, 2017 at 01:16:16PM +0200, Kashyap Chamarthy wrote:
> The test 192 ("Test NBD export with '-incoming' (non-shared
> storage migration use case from libvirt")) is currently using HMP.
> Replace the HMP usage with QMP, as the upstream preference seems to be:
> "Use QMP where possible, unless you're explicitly testing something
> related to HMP".
>
> While at it, convert the test from Bash to Python.
FYI This looks like it'll clash with the patch I sent to fix this
test case with LUKS
https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg00041.html
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2017-09-04 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 11:16 [Qemu-devel] [PATCH] qemu-iotests: Make test 192 use QMP; convert it to Python Kashyap Chamarthy
2017-09-04 12:55 ` Fam Zheng
2017-09-04 13:28 ` Kashyap Chamarthy
2017-09-05 19:37 ` Eric Blake
2017-09-08 10:06 ` Kashyap Chamarthy
2017-09-04 14:48 ` Daniel P. Berrange [this message]
2017-09-04 15:05 ` Kashyap Chamarthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904144812.GD27285@redhat.com \
--to=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=famz@redhat.com \
--cc=kchamart@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.