From: Marc Zyngier <marc.zyngier@arm.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] bus: arm-cci: Fix use of smp_processor_id() in preemptible context
Date: Mon, 4 Sep 2017 18:30:41 +0100 [thread overview]
Message-ID: <20170904173041.14119-3-marc.zyngier@arm.com> (raw)
In-Reply-To: <20170904173041.14119-1-marc.zyngier@arm.com>
The ARM CCI driver seem to be using smp_processor_id() in a
preemptible context, which is likely to make a DEBUG_PREMPT
kernel scream at boot time.
Turning this into a get_cpu()/put_cpu() should make it behave.
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
drivers/bus/arm-cci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index c49da15d9790..e2873789972a 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -1755,7 +1755,8 @@ static int cci_pmu_probe(struct platform_device *pdev)
raw_spin_lock_init(&cci_pmu->hw_events.pmu_lock);
mutex_init(&cci_pmu->reserve_mutex);
atomic_set(&cci_pmu->active_events, 0);
- cpumask_set_cpu(smp_processor_id(), &cci_pmu->cpus);
+ cpumask_set_cpu(get_cpu(), &cci_pmu->cpus);
+ put_cpu();
ret = cci_pmu_init(cci_pmu, pdev);
if (ret)
--
2.11.0
prev parent reply other threads:[~2017-09-04 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 17:30 [PATCH 0/2] bus: CCN/CCI: Fix use of smp_processor_id() Marc Zyngier
2017-09-04 17:30 ` [PATCH 1/2] bus: arm-ccn: Fix use of smp_processor_id() in preemptible context Marc Zyngier
2017-09-04 17:37 ` Mark Rutland
2017-09-04 17:59 ` Marc Zyngier
2017-09-04 17:30 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904173041.14119-3-marc.zyngier@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.