From: Tejun Heo <tj@kernel.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org,
Mika Kuoppala <mika.kuoppala@intel.com>,
Lai Jiangshan <jiangshanlai@gmail.com>
Subject: Re: [PATCH] drm/i915: Try harder to finish the idle-worker
Date: Tue, 5 Sep 2017 06:36:28 -0700 [thread overview]
Message-ID: <20170905133628.GD1774378@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20170904083549.4zh5apvueh5g6x74@phenom.ffwll.local>
On Mon, Sep 04, 2017 at 10:35:49AM +0200, Daniel Vetter wrote:
> On Fri, Sep 01, 2017 at 03:11:23PM +0100, Chris Wilson wrote:
> > If a worker requeues itself, it may switch to a different kworker pool,
> > which flush_work() considers as complete. To be strict, we then need to
> > keep flushing the work until it is no longer pending.
> >
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=102456
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Mika Kuoppala <mika.kuoppala@intel.com>
>
> Shouldn't this be a thing the workqueue subsystem exposes? Adding Tejun et
> al.
> -Daniel
Can't you use cancel[_delayed]_work_sync()?
Thanks.
--
tejun
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-05 13:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 14:11 [PATCH] drm/i915: Try harder to finish the idle-worker Chris Wilson
2017-09-01 14:57 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-09-04 8:35 ` [PATCH] " Daniel Vetter
2017-09-04 11:04 ` Chris Wilson
2017-09-05 13:36 ` Tejun Heo [this message]
2017-09-05 13:43 ` Chris Wilson
2017-09-05 13:48 ` Tejun Heo
2017-09-04 10:19 ` Mika Kuoppala
2017-09-04 10:49 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905133628.GD1774378@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jiangshanlai@gmail.com \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.