From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: berrange@redhat.com, pbonzini@redhat.com, qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH 1/3] io: Yield rather than wait when already in coroutine
Date: Tue, 5 Sep 2017 14:11:12 -0500 [thread overview]
Message-ID: <20170905191114.5959-2-eblake@redhat.com> (raw)
In-Reply-To: <20170905191114.5959-1-eblake@redhat.com>
The new qio_channel_{read,write}{,v}_all functions are documented
as yielding until data is available. When used on a blocking
channel, this yield is done via qio_channel_wait() which spawns
a new coroutine under the hood (so it is the new entry point that
yields as needed); but if we are already in a coroutine (at which
point QIO_CHANNEL_ERR_BLOCK is only possible if we are a
non-blocking channel), we want to yield the current coroutine
instead of spawning a new one.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
io/channel.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/io/channel.c b/io/channel.c
index 5e8c2f0a91..9e62794cab 100644
--- a/io/channel.c
+++ b/io/channel.c
@@ -105,7 +105,11 @@ int qio_channel_readv_all(QIOChannel *ioc,
ssize_t len;
len = qio_channel_readv(ioc, local_iov, nlocal_iov, errp);
if (len == QIO_CHANNEL_ERR_BLOCK) {
- qio_channel_wait(ioc, G_IO_IN);
+ if (qemu_in_coroutine()) {
+ qio_channel_yield(ioc, G_IO_IN);
+ } else {
+ qio_channel_wait(ioc, G_IO_IN);
+ }
continue;
} else if (len < 0) {
goto cleanup;
@@ -143,7 +147,11 @@ int qio_channel_writev_all(QIOChannel *ioc,
ssize_t len;
len = qio_channel_writev(ioc, local_iov, nlocal_iov, errp);
if (len == QIO_CHANNEL_ERR_BLOCK) {
- qio_channel_wait(ioc, G_IO_OUT);
+ if (qemu_in_coroutine()) {
+ qio_channel_yield(ioc, G_IO_OUT);
+ } else {
+ qio_channel_wait(ioc, G_IO_OUT);
+ }
continue;
}
if (len < 0) {
--
2.13.5
next prev parent reply other threads:[~2017-09-05 19:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 19:11 [Qemu-devel] [PATCH 0/3] nbd: Use common read/write-all qio functions Eric Blake
2017-09-05 19:11 ` Eric Blake [this message]
2017-09-06 8:50 ` [Qemu-devel] [PATCH 1/3] io: Yield rather than wait when already in coroutine Daniel P. Berrange
2017-09-06 14:53 ` Paolo Bonzini
2017-09-06 15:16 ` Eric Blake
2017-09-05 19:11 ` [Qemu-devel] [PATCH 2/3] io: Add new qio_channel_read{, v}_all_eof functions Eric Blake
2017-09-06 8:51 ` Daniel P. Berrange
2017-09-05 19:11 ` [Qemu-devel] [PATCH 3/3] nbd: Use new qio_channel_*_all() functions Eric Blake
2017-09-06 8:52 ` Daniel P. Berrange
2017-09-06 15:14 ` [Qemu-devel] [PATCH 0/3] nbd: Use common read/write-all qio functions Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905191114.5959-2-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.