From: Manasi Navare <manasi.d.navare@intel.com>
To: ville.syrjala@linux.intel.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm: Drop drm_get_link_status_name()
Date: Tue, 5 Sep 2017 12:23:03 -0700 [thread overview]
Message-ID: <20170905192303.GA2715@intel.com> (raw)
In-Reply-To: <20170901165328.24459-3-ville.syrjala@linux.intel.com>
On Fri, Sep 01, 2017 at 07:53:27PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> drm_get_link_status_name() isn't used so kill it.
>
> Fixes the following sparse warning:
> drm_connector.c:618:1: warning: symbol 'drm_get_link_status_name' was not declared. Should it be static?
>
Thanks for catching this warning.
Verified that this fixes the warning and hence drm_get_link_status_name not needed.
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
Manasi
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Fixes: 40ee6fbef75f ("drm: Add a new connector atomic property for link status")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/drm_connector.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index ba9f36cef68c..bb2e60f5feb6 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -615,7 +615,6 @@ static const struct drm_prop_enum_list drm_link_status_enum_list[] = {
> { DRM_MODE_LINK_STATUS_GOOD, "Good" },
> { DRM_MODE_LINK_STATUS_BAD, "Bad" },
> };
> -DRM_ENUM_NAME_FN(drm_get_link_status_name, drm_link_status_enum_list)
>
> /**
> * drm_display_info_set_bus_formats - set the supported bus formats
> --
> 2.13.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-09-05 19:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 16:53 [PATCH 1/4] drm: Make syncobj import/export functions static ville.syrjala
2017-09-01 16:53 ` [PATCH 2/4] drm: Add missing __user annotation to drm_syncobj_array_find() ville.syrjala
2017-09-01 17:44 ` Thierry Reding
2017-10-13 13:08 ` Ville Syrjälä
2017-09-01 16:53 ` [PATCH 3/4] drm: Drop drm_get_link_status_name() ville.syrjala
2017-09-01 17:46 ` Thierry Reding
2017-09-05 19:23 ` Manasi Navare [this message]
2017-09-01 16:53 ` [PATCH 4/4] drm: Make __drm_object_property_get_value() static ville.syrjala
2017-09-01 17:46 ` Thierry Reding
2017-09-01 17:44 ` [PATCH 1/4] drm: Make syncobj import/export functions static Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905192303.GA2715@intel.com \
--to=manasi.d.navare@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.