From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH] tpm_tis: make array cmd_getticks static const to shink object code size Date: Wed, 6 Sep 2017 14:31:49 +0300 Message-ID: <20170906113149.ygsyk7rv4iwileks@linux.intel.com> References: <20170825164505.23447-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170825164505.23447-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org To: Colin King Cc: Peter Huewe , Marcel Selhorst , Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org List-Id: tpmdd-devel@lists.sourceforge.net On Fri, Aug 25, 2017 at 05:45:05PM +0100, Colin King wrote: > From: Colin Ian King > > Don't populate array cmd_getticks on the stack, instead make it static > const. Makes the object code smaller by over 160 bytes: > > Before: > text data bss dec hex filename > 18813 3152 128 22093 564d drivers/char/tpm/tpm_tis_core.o > > After: > text data bss dec hex filename > 18554 3248 128 21930 55aa drivers/char/tpm/tpm_tis_core.o > > Signed-off-by: Colin Ian King > --- > drivers/char/tpm/tpm_tis_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c > index 63bc6c3b949e..1e957e923d21 100644 > --- a/drivers/char/tpm/tpm_tis_core.c > +++ b/drivers/char/tpm/tpm_tis_core.c > @@ -445,7 +445,7 @@ static int probe_itpm(struct tpm_chip *chip) > { > struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev); > int rc = 0; > - u8 cmd_getticks[] = { > + static const u8 cmd_getticks[] = { > 0x00, 0xc1, 0x00, 0x00, 0x00, 0x0a, > 0x00, 0x00, 0x00, 0xf1 > }; > -- > 2.14.1 > Applied. /Jarkko