From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 4/6] android: cve: Fix build of most of the tests
Date: Wed, 6 Sep 2017 15:20:12 +0200 [thread overview]
Message-ID: <20170906132012.GG24177@rei.lan> (raw)
In-Reply-To: <20170902005926.15923-5-petr.vorel@gmail.com>
Hi!
> +#if !defined(__ANDROID_API__) || __ANDROID_API__ >= 23
This looks ugly to me.
What is the exact problem here? Do the test fail to compile there? If so
we should really check for the missing feature and enable/disable the
test based on that rather than this hackery.
> #include <pty.h>
> #include <stdio.h>
> #include <string.h>
> @@ -159,3 +160,11 @@ static struct tst_test test = {
> .cleanup = cleanup,
> .test_all = run,
> };
> +#else /* Android API < 23 */
> +#define TST_NO_DEFAULT_MAIN
> +#include "tst_test.h"
> +int main(void)
> +{
> + tst_brk(TCONF, "test does not run on Android API < 23");
> +}
> +#endif
> --
> 2.14.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-09-06 13:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-02 0:59 [LTP] [RFC PATCH 0/6] cve: fixes for Android Petr Vorel
2017-09-02 0:59 ` [LTP] [RFC PATCH 1/6] android: cve: Disable building cve-2017-5669 Petr Vorel
2017-09-05 17:47 ` enh
2017-09-05 21:30 ` Sandeep Patil
2017-09-06 13:17 ` Cyril Hrubis
2017-09-11 21:41 ` Petr Vorel
2017-09-12 18:21 ` enh
2017-09-12 21:27 ` Petr Vorel
2017-09-12 23:58 ` enh
2017-09-19 23:46 ` Sandeep Patil
2017-09-02 0:59 ` [LTP] [RFC PATCH 2/6] android: lib: Add missing include for tst_safe_pthread.h Petr Vorel
2017-09-05 19:07 ` enh
2017-09-02 0:59 ` [LTP] [RFC PATCH 3/6] android: Add pty.h header Petr Vorel
2017-09-05 19:09 ` enh
2017-09-02 0:59 ` [LTP] [RFC PATCH 4/6] android: cve: Fix build of most of the tests Petr Vorel
2017-09-06 13:20 ` Cyril Hrubis [this message]
2017-09-02 0:59 ` [LTP] [RFC PATCH 5/6] android: cve/stack_clash: Fix PAGE_MASK defined in <sys/user.h> Petr Vorel
2017-09-06 13:34 ` Cyril Hrubis
2017-09-02 0:59 ` [LTP] [RFC PATCH 6/6] android: cve/stack_clash: Fix warning Petr Vorel
2017-09-06 13:21 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906132012.GG24177@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.