From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH v9 3/3] tools/libxc: use superpages during
 restore of HVM guest
Date: Wed, 6 Sep 2017 14:02:41 +0200
Message-ID: <20170906140241.1a09ccb1.olaf@aepfle.de>
References: <20170901160843.9057-1-olaf@aepfle.de>
 <20170901160843.9057-4-olaf@aepfle.de>
 <20170906113410.2upxmdambiwzvk5g@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3760563870632766579=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20170906113410.2upxmdambiwzvk5g@citrix.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

--===============3760563870632766579==
Content-Type: multipart/signed; micalg=pgp-sha1;
 boundary="Sig_/M_oEgVn1VHHHq/KMtzuCNfe"; protocol="application/pgp-signature"

--Sig_/M_oEgVn1VHHHq/KMtzuCNfe
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Am Wed, 6 Sep 2017 12:34:10 +0100
schrieb Wei Liu <wei.liu2@citrix.com>:

> > +struct x86_hvm_sp { =20
> Forgot to ask: what does sp stand for?

superpage. I will check if there is room to expand this string.

> > + * Try to allocate superpages.
> > + * This works without memory map only if the pfns arrive in incrementa=
l order.
> > + */ =20
> I have said several times, one way or another, I don't want to make
> assumption on the stream of pfns. So I'm afraid I can't ack a patch like
> this.

It will work with any order, I think. Just with incremental order the super=
pages will not be split once they are allocated.

Thanks for the review. I will send another series shortly.

Olaf

--Sig_/M_oEgVn1VHHHq/KMtzuCNfe
Content-Type: application/pgp-signature
Content-Description: Digitale Signatur von OpenPGP

-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCWa/j4QAKCRBdQqD6ppg2
fgF0AKCVu6WHu/NwHJIA6DOHcDdPDJiE4wCgoj9/ChXQRJ7tHlyHyym1UdRNmeA=
=wJhY
-----END PGP SIGNATURE-----

--Sig_/M_oEgVn1VHHHq/KMtzuCNfe--


--===============3760563870632766579==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============3760563870632766579==--