From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpbqk-0008RX-NE for qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:02:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpbqg-00019Y-1d for qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:02:42 -0400 Date: Wed, 6 Sep 2017 12:02:21 -0300 From: Eduardo Habkost Message-ID: <20170906150221.GB7570@localhost.localdomain> References: <20170906130041.GI3753@dhcp-200-186.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170906130041.GI3753@dhcp-200-186.str.redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] block-jobs: Optionally unregister live block operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Jeff Cody , qemu-devel@nongnu.org, qemu-block@nongnu.org, dgilbert@redhat.com, peterx@redhat.com, mrezanin@redhat.com On Wed, Sep 06, 2017 at 03:00:41PM +0200, Kevin Wolf wrote: > Am 30.08.2017 um 19:01 hat Jeff Cody geschrieben: > > From: Jeffrey Cody > > > > If configured without live block operations enabled, unregister the > > live block operation commands. > > > > Signed-off-by: Jeff Cody > > How sure are we that libvirt will like a qemu that advertises these > commands in the schema, but doesn't actually provide them? If libvirt wants to know if a command is available, it uses 'query-commands', not 'query-qmp-schema'. The only query-qmp-schema elements used by latest libvirt are gluster-related blockdev-add options (see libvirt/src/qemu/qemu_capabilities.c:virQEMUCapsQMPSchemaQueries]]). -- Eduardo