From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH rdma-core 3/3] mlx5: Add support for sending IPoIB packets
Date: Wed, 6 Sep 2017 10:04:43 -0600 [thread overview]
Message-ID: <20170906160443.GC6262@obsidianresearch.com> (raw)
In-Reply-To: <1504708729-15249-4-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On Wed, Sep 06, 2017 at 05:38:49PM +0300, Yishai Hadas wrote:
> + if (unlikely(qp->flags & MLX5_QP_FLAGS_USE_UNDERLAY)) {
> + err = mlx5_post_send_underlay(qp, wr, &seg, &size, &sg_copy_ptr);
> + if (unlikely(err)) {
> + *bad_wr = wr;
> + goto out;
> + }
> + }
I don't know anything about your device, but this patch looks to me
like it enables for any IBV_QP_CREATE_SOURCE_QPN user - and it seems
to contain a lot of IPoIB specific commentary.
It is wrong to assume that all IBV_QP_CREATE_SOURCE_QPN QP's are IPoIB.
At a minimum some of the commentary needs revising..
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-09-06 16:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 14:38 [PATCH rdma-core 0/3] Verbs support for source QPN Yishai Hadas
[not found] ` <1504708729-15249-1-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-09-06 14:38 ` [PATCH rdma-core 1/3] verbs: Enable creating QP with a given source QP number Yishai Hadas
2017-09-06 14:38 ` [PATCH rdma-core 2/3] mlx5: Add support for managing " Yishai Hadas
[not found] ` <1504708729-15249-3-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-09-06 15:12 ` Yuval Shaia
2017-09-06 15:56 ` Yishai Hadas
[not found] ` <1387444b-7c9d-d26c-d089-83b0d4b047d9-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-09-07 6:50 ` Yuval Shaia
[not found] ` <20170907065015.GA29974-aucZFOQYZpw5k8QU6pnCjNkmqwFzkYv6@public.gmane.org>
2017-09-07 15:13 ` Jason Gunthorpe
2017-09-06 14:38 ` [PATCH rdma-core 3/3] mlx5: Add support for sending IPoIB packets Yishai Hadas
[not found] ` <1504708729-15249-4-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-09-06 16:04 ` Jason Gunthorpe [this message]
[not found] ` <20170906160443.GC6262-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-09-06 16:49 ` Yishai Hadas
[not found] ` <4151c1be-89f3-804f-8feb-5e2b0b3947bc-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-09-06 16:53 ` Jason Gunthorpe
[not found] ` <20170906165334.GA12002-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-09-07 8:57 ` Yishai Hadas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906160443.GC6262@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.