From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-2512-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id 548155818038 for ; Wed, 6 Sep 2017 06:52:16 -0700 (PDT) Date: Wed, 6 Sep 2017 16:52:07 +0300 From: "Michael S. Tsirkin" Message-ID: <20170906164839-mutt-send-email-mst@kernel.org> References: <1503734014-239116-1-git-send-email-longpeng2@huawei.com> <59A8AE20.1080409@huawei.com> <7f0b8eb2-9e5c-7507-191d-1aab17c6ff0f@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f0b8eb2-9e5c-7507-191d-1aab17c6ff0f@linux.vnet.ibm.com> Subject: Re: [virtio-dev] Re: [Qemu-devel] [PATCH v19 0/2] virtio-crypto: virtio crypto device specification To: Halil Pasic Cc: "Longpeng (Mike)" , stefanha@redhat.com, qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, luonengjun@huawei.com, cohuck@redhat.com, denglingli@chinamobile.com, Jani.Kokkonen@huawei.com, Ola.Liljedahl@arm.com, Varun.Sethi@freescale.com, xin.zeng@intel.com, brian.a.keating@intel.com, liang.j.ma@intel.com, john.griffin@intel.com, weidong.huang@huawei.com, mike.caraman@nxp.com, agraf@suse.de, jasowang@redhat.com, nmorey@kalray.eu, vincent.jardin@6wind.com, arei.gonglei@hotmail.com, wangxinxin.wang@huawei.com List-ID: On Fri, Sep 01, 2017 at 01:45:45PM +0200, Halil Pasic wrote: > > > On 09/01/2017 02:47 AM, Longpeng (Mike) wrote: > > Ping... > > > > Stefan, Halil, do you have any suggestion ? > > > > Hi Longpeng, > > I've ran trough your patch, and it reads much better that > what I recall v18 used to read like. Because it's been a while > since v18 doing a conscious review on this will take a considerable > amount of time (my memories of the issues identified back then > are very sketchy/vague now). It's on my todo list, but it ain't the > only item there. I don't think it's a fair reason to delay the merging though. No comments in a while says time to merge to me. There's always a public review period during which more comments can be addressed. So I think we should start a ballot on this one. Mike - if you agree please open an issue in TC issue tracker. As a reminder here are the guidelines: -- When you open an issue (can be fixed afterwards as well): 1. Fill in the reporter in the Environment: field. 2. Shortly describe the issue in the description field Preferably add a URL to discussion here or in the comments. If the mail was copied to virtio-comment or virtio-dev, you can use mid.gmane.org/ to quickly locate a mail in the archives. 2. Preferably, fill in all affected versions: in "Affects Version/s:". This might not apply to e.g. improvement requests. --- When you propose the issue before the TC meeting: 1. Mark issue as Open 2. Fill in a summary of the final proposed change and link to full proposal in "Proposal" field. [any historical abandoned proposals and extra info can go into comments field] --- Then mail me and the TC and I will start a ballot. Thanks! > Btw. I like to have a reference implementation at hand when reviewing > a spec. What is the status of the (reference) implementation (I mean > the new stuff like stateless/mux)? I think it would be nice to provide > this info in the cover letter (e.g. next time, should we need another > iteration). > > Regards, > Halil > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpakj-000189-P1 for qemu-devel@nongnu.org; Wed, 06 Sep 2017 09:52:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpaka-0002NM-2w for qemu-devel@nongnu.org; Wed, 06 Sep 2017 09:52:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41524) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dpakZ-0002Mf-QC for qemu-devel@nongnu.org; Wed, 06 Sep 2017 09:52:16 -0400 Date: Wed, 6 Sep 2017 16:52:07 +0300 From: "Michael S. Tsirkin" Message-ID: <20170906164839-mutt-send-email-mst@kernel.org> References: <1503734014-239116-1-git-send-email-longpeng2@huawei.com> <59A8AE20.1080409@huawei.com> <7f0b8eb2-9e5c-7507-191d-1aab17c6ff0f@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f0b8eb2-9e5c-7507-191d-1aab17c6ff0f@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [virtio-dev] Re: [PATCH v19 0/2] virtio-crypto: virtio crypto device specification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Halil Pasic Cc: "Longpeng (Mike)" , stefanha@redhat.com, qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, luonengjun@huawei.com, cohuck@redhat.com, denglingli@chinamobile.com, Jani.Kokkonen@huawei.com, Ola.Liljedahl@arm.com, Varun.Sethi@freescale.com, xin.zeng@intel.com, brian.a.keating@intel.com, liang.j.ma@intel.com, john.griffin@intel.com, weidong.huang@huawei.com, mike.caraman@nxp.com, agraf@suse.de, jasowang@redhat.com, nmorey@kalray.eu, vincent.jardin@6wind.com, arei.gonglei@hotmail.com, wangxinxin.wang@huawei.com On Fri, Sep 01, 2017 at 01:45:45PM +0200, Halil Pasic wrote: > > > On 09/01/2017 02:47 AM, Longpeng (Mike) wrote: > > Ping... > > > > Stefan, Halil, do you have any suggestion ? > > > > Hi Longpeng, > > I've ran trough your patch, and it reads much better that > what I recall v18 used to read like. Because it's been a while > since v18 doing a conscious review on this will take a considerable > amount of time (my memories of the issues identified back then > are very sketchy/vague now). It's on my todo list, but it ain't the > only item there. I don't think it's a fair reason to delay the merging though. No comments in a while says time to merge to me. There's always a public review period during which more comments can be addressed. So I think we should start a ballot on this one. Mike - if you agree please open an issue in TC issue tracker. As a reminder here are the guidelines: -- When you open an issue (can be fixed afterwards as well): 1. Fill in the reporter in the Environment: field. 2. Shortly describe the issue in the description field Preferably add a URL to discussion here or in the comments. If the mail was copied to virtio-comment or virtio-dev, you can use mid.gmane.org/ to quickly locate a mail in the archives. 2. Preferably, fill in all affected versions: in "Affects Version/s:". This might not apply to e.g. improvement requests. --- When you propose the issue before the TC meeting: 1. Mark issue as Open 2. Fill in a summary of the final proposed change and link to full proposal in "Proposal" field. [any historical abandoned proposals and extra info can go into comments field] --- Then mail me and the TC and I will start a ballot. Thanks! > Btw. I like to have a reference implementation at hand when reviewing > a spec. What is the status of the (reference) implementation (I mean > the new stuff like stateless/mux)? I think it would be nice to provide > this info in the cover letter (e.g. next time, should we need another > iteration). > > Regards, > Halil > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org