All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/luvi: needs git submodules
Date: Wed, 6 Sep 2017 23:16:57 +0200	[thread overview]
Message-ID: <20170906231657.382c5f79@windsurf.lan> (raw)
In-Reply-To: <20170904053114.16477-1-bernd.kuhls@t-online.de>

Hello J?rg,

Since you are listed in the DEVELOPERS file for this package, could you
comment/review/ack the below patch from Bernd touching luvi ?

Of course, git submodules and bundled libraries are not really nice,
which is why I'm seeking your opinion.

Thanks!

Thomas

On Mon,  4 Sep 2017 07:31:14 +0200, Bernd Kuhls wrote:
> Luvi bundles several libraries previously provided by the upstream
> tarball. Since the tarball is not available anymore we need to fetch
> the git submodules.
> 
> Fixes
> http://autobuild.buildroot.net/results/26d/26d04350a761d362f40e7bd1ac09b639d61de91a/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/luvi/luvi.hash | 2 +-
>  package/luvi/luvi.mk   | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/luvi/luvi.hash b/package/luvi/luvi.hash
> index 7f7abdbf4..ce3785eb8 100644
> --- a/package/luvi/luvi.hash
> +++ b/package/luvi/luvi.hash
> @@ -1,2 +1,2 @@
>  # Locally calculated
> -sha256 65d3ded5007d5bb58fc3b76013913596fd42ed7326310d67c668ddf9a017a179  luvi-v2.7.6.tar.gz
> +sha256 6d2297751b4d4023c1fa8b723b6f04e09584c67694958edbfa0d284f384759d5  luvi-v2.7.6.tar.gz
> diff --git a/package/luvi/luvi.mk b/package/luvi/luvi.mk
> index 7dd5e5a32..fc89d4d65 100644
> --- a/package/luvi/luvi.mk
> +++ b/package/luvi/luvi.mk
> @@ -5,7 +5,8 @@
>  ################################################################################
>  
>  LUVI_VERSION = v2.7.6
> -LUVI_SITE = $(call github,luvit,luvi,$(LUVI_VERSION))
> +LUVI_SITE = git://github.com/luvit/luvi.git
> +LUVI_GIT_SUBMODULES = YES
>  LUVI_LICENSE = Apache-2.0
>  LUVI_LICENSE_FILES = LICENSE.txt
>  LUVI_DEPENDENCIES = libuv luajit luv host-luajit



-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-09-06 21:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-04  5:31 [Buildroot] [PATCH 1/1] package/luvi: needs git submodules Bernd Kuhls
2017-09-06 21:16 ` Thomas Petazzoni [this message]
2017-09-07 10:10   ` Jörg Krause
2017-09-19 20:59     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170906231657.382c5f79@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.