From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755009AbdIGJcT (ORCPT ); Thu, 7 Sep 2017 05:32:19 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:38187 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754941AbdIGJcP (ORCPT ); Thu, 7 Sep 2017 05:32:15 -0400 X-ME-Sender: X-Sasl-enc: Tr+ihKeufw5iOV4uNCJHxwVJYeQCbJUxnD8bijRSO02M 1504776734 Date: Thu, 7 Sep 2017 11:32:13 +0200 From: Greg KH To: Pushkar Jambhlekar Cc: Stephen Rothwell , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/staging/pi433: Fixing coding guidelines Message-ID: <20170907093213.GC8102@kroah.com> References: <1504676522-3049-1-git-send-email-pushkar.iit@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504676522-3049-1-git-send-email-pushkar.iit@gmail.com> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 06, 2017 at 11:12:02AM +0530, Pushkar Jambhlekar wrote: > Fix brace style of if-else case > > Signed-off-by: Pushkar Jambhlekar > --- > drivers/staging/pi433/pi433_if.c | 162 +++++++++++++-------------------------- > 1 file changed, 54 insertions(+), 108 deletions(-) > > diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c > index 93c0168..c070cf3 100644 > --- a/drivers/staging/pi433/pi433_if.c > +++ b/drivers/staging/pi433/pi433_if.c > @@ -133,19 +133,16 @@ static irqreturn_t DIO0_irq_handler(int irq, void *dev_id) > { > struct pi433_device *device = dev_id; > > - if (device->irq_state[DIO0] == DIO_PacketSent) > - { > + if (device->irq_state[DIO0] == DIO_PacketSent) { Those extra spaces after "if" really don't need to be there either, right? Fix that at the same time please. thanks, greg k-h