From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pushkar Jambhlekar <pushkar.iit@gmail.com>
Cc: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>,
William Blough <devel@blough.us>,
Ivan Safonov <insafonov@gmail.com>,
Yamanappagouda Patil <goudapatilk@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/staging/rtl8188eu: cleanup crc32_init logic
Date: Thu, 7 Sep 2017 11:33:48 +0200 [thread overview]
Message-ID: <20170907093348.GD8102@kroah.com> (raw)
In-Reply-To: <1504759852-2053-1-git-send-email-pushkar.iit@gmail.com>
On Thu, Sep 07, 2017 at 10:20:52AM +0530, Pushkar Jambhlekar wrote:
> crc32_init is using unnecessary else condition. Cleaningup this function
>
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_security.c | 42 +++++++++++++--------------
> 1 file changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
> index b283a490..9d17204 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_security.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_security.c
> @@ -94,29 +94,29 @@ static u8 crc32_reverseBit(u8 data)
>
> static void crc32_init(void)
> {
> - if (bcrc32initialized == 1) {
> + if (bcrc32initialized == 1)
> return;
> - } else {
> - int i, j;
> - u32 c;
> - u8 *p = (u8 *)&c, *p1;
> - u8 k;
> -
> - c = 0x12340000;
> -
> - for (i = 0; i < 256; ++i) {
> - k = crc32_reverseBit((u8)i);
> - for (c = ((u32)k) << 24, j = 8; j > 0; --j)
> - c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
> - p1 = (u8 *)&crc32_table[i];
> -
> - p1[0] = crc32_reverseBit(p[3]);
> - p1[1] = crc32_reverseBit(p[2]);
> - p1[2] = crc32_reverseBit(p[1]);
> - p1[3] = crc32_reverseBit(p[0]);
> - }
> - bcrc32initialized = 1;
> +
> + int i, j;
> + u32 c;
> + u8 *p = (u8 *)&c, *p1;
> + u8 k;
> +
> + c = 0x12340000;
> +
> + for (i = 0; i < 256; ++i) {
> + k = crc32_reverseBit((u8)i);
> + for (c = ((u32)k) << 24, j = 8; j > 0; --j)
> + c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
> + p1 = (u8 *)&crc32_table[i];
> +
> + p1[0] = crc32_reverseBit(p[3]);
> + p1[1] = crc32_reverseBit(p[2]);
> + p1[2] = crc32_reverseBit(p[1]);
> + p1[3] = crc32_reverseBit(p[0]);
> }
> +
> + bcrc32initialized = 1;
> }
>
> static __le32 getcrc32(u8 *buf, int len)
Always test build your code and ensure that you did not add any new
build warnings or errors :(
prev parent reply other threads:[~2017-09-07 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 4:50 [PATCH] drivers/staging/rtl8188eu: cleanup crc32_init logic Pushkar Jambhlekar
2017-09-07 9:33 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907093348.GD8102@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@blough.us \
--cc=devel@driverdev.osuosl.org \
--cc=georgiana.chelu93@gmail.com \
--cc=goudapatilk@gmail.com \
--cc=insafonov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pushkar.iit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.